Re: [PATCH 2/2] watchdog: as3722_wdt: support for AMS AS3722

Guenter Roeck
2013-11-22T04:07:10Z

On 11/20/2013 02:33 PM, Bibek Basu wrote:
> Add watchdog timer driver for as3722 device.
> The timer can be start/stop and set timing through
> watchdog subsystem callbacks.
>
> Change-Id: I5e252fd762764afaa1598cd98fed91864dc23d8d
> Signed-off-by: Bibek Basu <bbasu@nvidia.com>

[ ... ]

> + wdt_dev->info = &as3722_wdt_info;
> + wdt_dev->ops = &as3722_wdt_ops;
> + wdt_dev->timeout = 128;

One more comment:

Unless I am missing something, this won't work if timer_initial_period is set.

If the watchdog is opened without explicitly setting a timeout,
the chip timeout will still be set to the value of initial_timeout,
while the watchdog susbystem will believe it to be 128 seconds,
and report that value to userspace when asked.
If initial_timeout is low, say, less than 60 seconds, the watchdog
will not be updated in time by userspace, since userspace will believe
that the timeout is 128 seconds and likely only ping the watchdog
every 64 seconds or so.

Guenter