From: Guenter Roeck <linux@roeck-us.net>
To: Bibek Basu <bbasu@nvidia.com>,
wim@iguana.be, linux-watchdog@vger.kernel.org,
lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: as3722_wdt: support for AMS AS3722
Date: Thu, 21 Nov 2013 19:51:02 -0800 [thread overview]
Message-ID: <528ED4A6.5070807@roeck-us.net> (raw)
In-Reply-To: <1384986810-10952-2-git-send-email-bbasu@nvidia.com>
On 11/20/2013 02:33 PM, Bibek Basu wrote:
> Add watchdog timer driver for as3722 device.
> The timer can be start/stop and set timing through
> watchdog subsystem callbacks.
>
> Change-Id: I5e252fd762764afaa1598cd98fed91864dc23d8d
> Signed-off-by: Bibek Basu <bbasu@nvidia.com>
[ ... ]
> + wdt_dev->info = &as3722_wdt_info;
> + wdt_dev->ops = &as3722_wdt_ops;
> + wdt_dev->timeout = 128;
One more comment:
Unless I am missing something, this won't work if timer_initial_period is set.
If the watchdog is opened without explicitly setting a timeout,
the chip timeout will still be set to the value of initial_timeout,
while the watchdog susbystem will believe it to be 128 seconds,
and report that value to userspace when asked.
If initial_timeout is low, say, less than 60 seconds, the watchdog
will not be updated in time by userspace, since userspace will believe
that the timeout is 128 seconds and likely only ping the watchdog
every 64 seconds or so.
Guenter
next prev parent reply other threads:[~2013-11-22 4:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 22:33 [PATCH 1/2] mfd: as3722: add watchdog support Bibek Basu
2013-11-20 22:33 ` [PATCH 2/2] watchdog: as3722_wdt: support for AMS AS3722 Bibek Basu
2013-11-22 3:38 ` Guenter Roeck
2013-11-22 3:51 ` Guenter Roeck [this message]
2013-11-21 9:17 ` [PATCH 1/2] mfd: as3722: add watchdog support Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528ED4A6.5070807@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bbasu@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox