From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: David Ahern <dsahern@gmail.com>,
mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf util: optimize util/machine.c:machines__find().
Date: Fri, 22 Nov 2013 13:59:26 -0500 [thread overview]
Message-ID: <528FA98E.4080708@cn.fujitsu.com> (raw)
In-Reply-To: <20131122000608.GA2117@ghostprotocols.net>
On 11/21/2013 07:06 PM, Arnaldo Carvalho de Melo wrote:
>
>> This changes machines__find to always return the machine for the
>> host (pid == 0). This function is also used for VM lookups.
> Nope:
>
> /* Native host kernel uses -1 as pid index in machine */
> #define HOST_KERNEL_ID (-1)
> #define DEFAULT_GUEST_KERNEL_ID (0)
>
> But I fail to see the point of the "optimization", we're looking for a
> pid, not always for '0'.
>
> And the changelog is horrible, why is it "unnecessary"? Please don't be
> so terse :-)
>
> - Arnaldo
>
Hi David and Arnaldo,
It is my mistake about it!! The original code does the right thing.
Sorry to bother you, I am a newbie for perf.
I will send a patch after second and third thought next time.
Thanx for your reply.
- Yang
prev parent reply other threads:[~2013-11-22 6:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 21:31 [PATCH] perf util: optimize util/machine.c:machines__find() Dongsheng Yang
2013-11-21 21:16 ` David Ahern
2013-11-22 0:06 ` Arnaldo Carvalho de Melo
2013-11-22 18:59 ` Dongsheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528FA98E.4080708@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox