* [PATCH] dt-bindings: add ARMv8 PMU binding
@ 2013-11-22 21:17 Rob Herring
2013-11-22 21:38 ` Kumar Gala
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2013-11-22 21:17 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: Rob Herring, Will Deacon, Pawel Moll, Mark Rutland, Ian Campbell
From: Rob Herring <rob.herring@calxeda.com>
Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
---
Documentation/devicetree/bindings/arm/pmu.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
index 343781b..3e1e498 100644
--- a/Documentation/devicetree/bindings/arm/pmu.txt
+++ b/Documentation/devicetree/bindings/arm/pmu.txt
@@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
Required properties:
- compatible : should be one of
+ "arm,armv8-pmuv3"
"arm,cortex-a15-pmu"
"arm,cortex-a9-pmu"
"arm,cortex-a8-pmu"
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: add ARMv8 PMU binding
2013-11-22 21:17 [PATCH] dt-bindings: add ARMv8 PMU binding Rob Herring
@ 2013-11-22 21:38 ` Kumar Gala
2013-11-22 21:43 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Kumar Gala @ 2013-11-22 21:38 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Rob Herring, Will Deacon, Pawel Moll,
Mark Rutland, Ian Campbell
On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2@gmail.com> wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> ---
> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> index 343781b..3e1e498 100644
> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
> Required properties:
>
> - compatible : should be one of
> + "arm,armv8-pmuv3”
what about arm,armv8-pmu-v3?
- k
> "arm,cortex-a15-pmu"
> "arm,cortex-a9-pmu"
> "arm,cortex-a8-pmu"
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: add ARMv8 PMU binding
2013-11-22 21:38 ` Kumar Gala
@ 2013-11-22 21:43 ` Rob Herring
2013-11-25 9:16 ` Mark Rutland
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2013-11-22 21:43 UTC (permalink / raw)
To: Kumar Gala
Cc: devicetree, linux-kernel, Will Deacon, Pawel Moll, Mark Rutland,
Ian Campbell
On 11/22/2013 03:38 PM, Kumar Gala wrote:
>
> On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2@gmail.com> wrote:
>
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
>>
>> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Pawel Moll <pawel.moll@arm.com>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
>> ---
>> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
>> index 343781b..3e1e498 100644
>> --- a/Documentation/devicetree/bindings/arm/pmu.txt
>> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
>> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
>> Required properties:
>>
>> - compatible : should be one of
>> + "arm,armv8-pmuv3”
>
> what about arm,armv8-pmu-v3?
I'm just documenting what is already being used:
arch/arm64/boot/dts/foundation-v8.dts: compatible =
"arm,armv8-pmuv3";
arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
"arm,armv8-pmuv3";
Do we want to change those?
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: add ARMv8 PMU binding
2013-11-22 21:43 ` Rob Herring
@ 2013-11-25 9:16 ` Mark Rutland
2013-11-25 15:24 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Mark Rutland @ 2013-11-25 9:16 UTC (permalink / raw)
To: Rob Herring
Cc: Kumar Gala, devicetree, linux-kernel@vger.kernel.org, Will Deacon,
Pawel Moll, Ian Campbell
On Fri, Nov 22, 2013 at 09:43:31PM +0000, Rob Herring wrote:
> On 11/22/2013 03:38 PM, Kumar Gala wrote:
> >
> > On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2@gmail.com> wrote:
> >
> >> From: Rob Herring <rob.herring@calxeda.com>
> >>
> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
> >>
> >> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> >> Cc: Will Deacon <will.deacon@arm.com>
> >> Cc: Pawel Moll <pawel.moll@arm.com>
> >> Cc: Mark Rutland <mark.rutland@arm.com>
> >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> >> ---
> >> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> >> index 343781b..3e1e498 100644
> >> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> >> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
> >> Required properties:
> >>
> >> - compatible : should be one of
> >> + "arm,armv8-pmuv3”
> >
> > what about arm,armv8-pmu-v3?
>
> I'm just documenting what is already being used:
>
> arch/arm64/boot/dts/foundation-v8.dts: compatible =
> "arm,armv8-pmuv3";
> arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
> "arm,armv8-pmuv3";
>
> Do we want to change those?
It would probably have been nicer to have the '-' from the start, but
adding it now is only going to expand the set of compatible strings for
no appreciable benefit.
I don't see any value in adding a new form of the string, and we can't
change the existing one as it's already in use.
Thanks,
Mark.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: add ARMv8 PMU binding
2013-11-25 9:16 ` Mark Rutland
@ 2013-11-25 15:24 ` Rob Herring
2013-11-25 16:01 ` Mark Rutland
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2013-11-25 15:24 UTC (permalink / raw)
To: Mark Rutland
Cc: Kumar Gala, devicetree, linux-kernel@vger.kernel.org, Will Deacon,
Pawel Moll, Ian Campbell
On Mon, Nov 25, 2013 at 3:16 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> On Fri, Nov 22, 2013 at 09:43:31PM +0000, Rob Herring wrote:
>> On 11/22/2013 03:38 PM, Kumar Gala wrote:
>> >
>> > On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2@gmail.com> wrote:
>> >
>> >> From: Rob Herring <rob.herring@calxeda.com>
>> >>
>> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
>> >>
>> >> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>> >> Cc: Will Deacon <will.deacon@arm.com>
>> >> Cc: Pawel Moll <pawel.moll@arm.com>
>> >> Cc: Mark Rutland <mark.rutland@arm.com>
>> >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
>> >> ---
>> >> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
>> >> 1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
>> >> index 343781b..3e1e498 100644
>> >> --- a/Documentation/devicetree/bindings/arm/pmu.txt
>> >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
>> >> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
>> >> Required properties:
>> >>
>> >> - compatible : should be one of
>> >> + "arm,armv8-pmuv3”
>> >
>> > what about arm,armv8-pmu-v3?
>>
>> I'm just documenting what is already being used:
>>
>> arch/arm64/boot/dts/foundation-v8.dts: compatible =
>> "arm,armv8-pmuv3";
>> arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
>> "arm,armv8-pmuv3";
>>
>> Do we want to change those?
>
> It would probably have been nicer to have the '-' from the start, but
> adding it now is only going to expand the set of compatible strings for
> no appreciable benefit.
>
> I don't see any value in adding a new form of the string, and we can't
> change the existing one as it's already in use.
Is that an ack then?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: add ARMv8 PMU binding
2013-11-25 15:24 ` Rob Herring
@ 2013-11-25 16:01 ` Mark Rutland
0 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2013-11-25 16:01 UTC (permalink / raw)
To: Rob Herring
Cc: Kumar Gala, devicetree, linux-kernel@vger.kernel.org, Will Deacon,
Pawel Moll, Ian Campbell
On Mon, Nov 25, 2013 at 03:24:46PM +0000, Rob Herring wrote:
> On Mon, Nov 25, 2013 at 3:16 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Fri, Nov 22, 2013 at 09:43:31PM +0000, Rob Herring wrote:
> >> On 11/22/2013 03:38 PM, Kumar Gala wrote:
> >> >
> >> > On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2@gmail.com> wrote:
> >> >
> >> >> From: Rob Herring <rob.herring@calxeda.com>
> >> >>
> >> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
> >> >>
> >> >> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> >> >> Cc: Will Deacon <will.deacon@arm.com>
> >> >> Cc: Pawel Moll <pawel.moll@arm.com>
> >> >> Cc: Mark Rutland <mark.rutland@arm.com>
> >> >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> >> >> ---
> >> >> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> >> >> 1 file changed, 1 insertion(+)
> >> >>
> >> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> index 343781b..3e1e498 100644
> >> >> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
> >> >> Required properties:
> >> >>
> >> >> - compatible : should be one of
> >> >> + "arm,armv8-pmuv3”
> >> >
> >> > what about arm,armv8-pmu-v3?
> >>
> >> I'm just documenting what is already being used:
> >>
> >> arch/arm64/boot/dts/foundation-v8.dts: compatible =
> >> "arm,armv8-pmuv3";
> >> arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
> >> "arm,armv8-pmuv3";
> >>
> >> Do we want to change those?
> >
> > It would probably have been nicer to have the '-' from the start, but
> > adding it now is only going to expand the set of compatible strings for
> > no appreciable benefit.
> >
> > I don't see any value in adding a new form of the string, and we can't
> > change the existing one as it's already in use.
>
> Is that an ack then?
>
Sure:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-25 16:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-22 21:17 [PATCH] dt-bindings: add ARMv8 PMU binding Rob Herring
2013-11-22 21:38 ` Kumar Gala
2013-11-22 21:43 ` Rob Herring
2013-11-25 9:16 ` Mark Rutland
2013-11-25 15:24 ` Rob Herring
2013-11-25 16:01 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox