From: Roland Dreier <roland@topspin.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: long <tlnguyen@snoqualmie.dp.intel.com>,
akpm@osdl.org, greg@kroah.com, linux-kernel@vger.kernel.org,
tom.l.nguyen@intel.com
Subject: Re: [PATCH]2.6.7 MSI-X Update
Date: Tue, 22 Jun 2004 18:18:13 -0700 [thread overview]
Message-ID: <528yefkr6y.fsf@topspin.com> (raw)
In-Reply-To: <40D8CE3F.4010306@pobox.com> (Jeff Garzik's message of "Tue, 22 Jun 2004 20:26:39 -0400")
Jeff> hmmmmmmm.
Jeff> Unless it's already inside the lock somehow... it
Jeff> definitely needs to take the lock, one way or another.
At least most (in not all) of the code paths are not inside the lock.
For example pci_enable_msi() is called from a device driver, and it
directly does
dev->bus->ops->read(dev->bus, dev->devfn, msi_control_reg(pos),
2, &control);
as well as calling lots of other functions that do similar stuff.
In fact I don't see how any of the stuff in msi.c could be protected
by pci_lock, since pci_lock is static to access.c and only used inside
the pci_bus_read_config_xxx and pci_bus_write_config_xxx functions
defined there.
- Roland
next prev parent reply other threads:[~2004-06-23 1:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 21:48 [PATCH]2.6.7 MSI-X Update long
2004-06-22 23:57 ` Roland Dreier
2004-06-23 0:26 ` Jeff Garzik
2004-06-23 1:18 ` Roland Dreier [this message]
2004-06-23 3:45 ` Roland Dreier
2004-06-23 16:50 ` Roland Dreier
-- strict thread matches above, loose matches on Subject: below --
2004-06-22 23:06 Nguyen, Tom L
2004-06-23 16:49 Nguyen, Tom L
2004-06-23 16:58 Nguyen, Tom L
2004-06-23 22:03 Nguyen, Tom L
2004-06-24 1:42 ` Roland Dreier
2004-06-24 6:37 ` Zwane Mwaikambo
2004-06-24 7:27 ` Roland Dreier
2004-06-24 16:29 Nguyen, Tom L
2004-06-26 1:21 long
2004-06-26 0:30 ` [PATCH]2.6.7 " Roland Dreier
2004-06-26 1:38 ` Roland Dreier
2004-06-26 8:27 ` Christoph Hellwig
2004-06-26 17:30 ` Roland Dreier
2004-07-13 22:02 long
2004-07-15 2:14 ` [PATCH]2.6.7 " Roland Dreier
2004-07-18 1:25 ` Roland Dreier
2004-07-15 15:46 Nguyen, Tom L
2004-07-19 15:36 Nguyen, Tom L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528yefkr6y.fsf@topspin.com \
--to=roland@topspin.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tlnguyen@snoqualmie.dp.intel.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox