From: Jonathan Cameron <jic23@kernel.org>
To: NeilBrown <neilb@suse.de>, Mark Rutland <mark.rutland@arm.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Manuel Stahl <manuel.stahl@iis.fraunhofer.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] itg3200: add dt support.
Date: Sat, 23 Nov 2013 18:46:45 +0000 [thread overview]
Message-ID: <5290F815.10102@kernel.org> (raw)
In-Reply-To: <20131119095625.1fc4f66f@notabene.brown>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/18/13 22:56, NeilBrown wrote:
> On Mon, 18 Nov 2013 11:57:42 +0000 Mark Rutland <mark.rutland@arm.com> wrote:
>
>> On Fri, Nov 01, 2013 at 04:48:54AM +0000, NeilBrown wrote:
>>>
>>>
>>> No new configuration, just a 'compatible' string and documentation.
>>>
>>> Signed-off-by: NeilBrown <neilb@suse.de>
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/gyro/itg3200.txt
>>> b/Documentation/devicetree/bindings/iio/gyro/itg3200.txt new file mode 100644 index 000000000000..4581620632df
>>> --- /dev/null +++ b/Documentation/devicetree/bindings/iio/gyro/itg3200.txt @@ -0,0 +1,20 @@ +* InvenSense
>>> ITG3200 3-axis gyroscope + +Required properties: + + - compatible : "invensense,itg3200" + - reg : I2C
>>> address, typically 0x68 + +Optional properties: + + - interrupt-parent : should be the phandle for the
>>> interrupt controller + - interrupts : interrupt mapping for GPIO IRQ
>>
>> Why is this a "GPIO IRQ"? This device das no GPIO. The fact that it might be wired to a GPIO controller has
>> nothing to do with the ITG3200, and shouldn't be a concern of its binding.
>>
>
> You are of course correct. I'll resubmit with that word removed.
>
> I probably copied it from bma180.txt without thinking.
>
> /home/git/linux$ git grep 'GPIO IRQ' Documentation/devicetree/bindings/
> Documentation/devicetree/bindings/gpio/8xxx_gpio.txt: - interrupts : Interrupt mapping for GPIO IRQ.
> Documentation/devicetree/bindings/gpio/gpio-xilinx.txt:- interrupts : Interrupt mapping for GPIO IRQ.
> Documentation/devicetree/bindings/gpio/pl061-gpio.txt:- interrupts : Interrupt mapping for GPIO IRQ.
> Documentation/devicetree/bindings/iio/accel/bma180.txt: - interrupts : interrupt mapping for GPIO IRQ, it should
> by configured wi Documentation/devicetree/bindings/iio/light/apds9300.txt: - interrupts : interrupt mapping for
> GPIO IRQ
>
> Both bma180.txt and apds9300.txt seem to use the phrase "GPIO IRQ" inappropriately.
Fixes are always welcome ;)
Jonathan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSkPgVAAoJEFSFNJnE9BaI2HwQALgU62ckBDUiDCxImT7vfdRC
ey6YP5REWO+J8igW6pvjq+mElj2QjQcnbKbuGbEsEFM5f1tZ8+udjsJ0teZyyO30
+P42S6UsGuGEru3KBwU/m46aASYOtKiTeRcYsOq+DGM8DixTDDtRU7tlIwCA11tJ
49SH4aK0T8ktV2Cu4184TkoWNOhHdd1Qwbc8K2xQqxO94t/xgXXCLJe6trKZFC7A
5jQwex+wZnJcxEduSN5LJgi1BqgXIUzoImVZyyZ2nxaVhHPJld5a4VCAGTcaBYLf
jZQYOp1LstS3/Rx1KcKRMyPt0y9j58ZpmP/rGbX3jrKmg0WL5hq9HP53BXdXTpOu
fXilORCDqdf4g2n2pRO+UONE3foVfXPlYfxYQ1KxIVIZNptYEUE5cvKQA7Oafl42
kUpQPbgdnq8Jlnh2+HalxN8Wn0oav3Iljugya+HSjJnnt/TLUxM3bwn84rA3qae7
kbmvzA2ag8CS01dLVu7tGOGthFiV2DAosIVbdFiyPBdS0rFM8QVa2s/oVJr5UyBt
2d/VYOPwSYJbWwMSRM/zdrpRKiXBtpiYsR6aqFWu9vuploaW7i29P6YB7h69+CYw
lLVw8uIYuH+6FIlD/tbhmmKLPo6gMPCVrS7/qQWmzoyT6eKnX5Ys+N8kH6NVA2iS
UeJ82ZYn2sWcuriM17W1
=msEy
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2013-11-23 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 4:48 [PATCH] itg3200: add dt support NeilBrown
2013-11-18 11:57 ` Mark Rutland
2013-11-18 22:56 ` NeilBrown
2013-11-23 18:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5290F815.10102@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.stahl@iis.fraunhofer.de \
--cc=mark.rutland@arm.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).