From: jonghwa3.lee@samsung.com
To: Austin Boyle <boyle.austin@gmail.com>
Cc: Anton Vorontsov <anton@enomsg.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Myungjoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config
Date: Mon, 25 Nov 2013 09:40:04 +0900 [thread overview]
Message-ID: <52929C64.2090903@samsung.com> (raw)
In-Reply-To: <20131124214149.cf1b6444d6e43d637ea7e34b@gmail.com>
On 2013년 11월 24일 19:41, Austin Boyle wrote:
> max17042 now uses regmap interface but does not enable config option. This patch fixes the following build errors:
>
> drivers/power/max17042_battery.c:661:15: error: variable ‘max17042_regmap_config’ has initializer but incomplete type
> drivers/power/max17042_battery.c:662:2: error: unknown field ‘reg_bits’ specified in initializer
> drivers/power/max17042_battery.c:662:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:662:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c:663:2: error: unknown field ‘val_bits’ specified in initializer
> drivers/power/max17042_battery.c:663:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:663:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c:664:2: error: unknown field ‘val_format_endian’ specified in initializer
> drivers/power/max17042_battery.c:664:23: error: ‘REGMAP_ENDIAN_NATIVE’ undeclared here (not in a function)
> drivers/power/max17042_battery.c:664:2: warning: excess elements in struct initializer
> drivers/power/max17042_battery.c:664:2: warning: (near initialization for ‘max17042_regmap_config’)
> drivers/power/max17042_battery.c: In function ‘max17042_probe’:
> drivers/power/max17042_battery.c:684:2: error: implicit declaration of function ‘devm_regmap_init_i2c’
>
> Signed-off-by: Austin Boyle <boyle.austin@gmail.com>
> ---
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 5e2054a..85ad58c 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -196,6 +196,7 @@ config BATTERY_MAX17040
> config BATTERY_MAX17042
> tristate "Maxim MAX17042/17047/17050/8997/8966 Fuel Gauge"
> depends on I2C
> + select REGMAP_I2C
> help
> MAX17042 is fuel-gauge systems for lithium-ion (Li+) batteries
> in handheld and portable equipment. The MAX17042 is configured
>
Sorry, It's my fault. Thanks.
Acked-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
next prev parent reply other threads:[~2013-11-25 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 10:41 [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config Austin Boyle
2013-11-25 0:40 ` jonghwa3.lee [this message]
2013-12-01 22:26 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52929C64.2090903@samsung.com \
--to=jonghwa3.lee@samsung.com \
--cc=anton@enomsg.org \
--cc=boyle.austin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox