From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751700Ab3KYJ0M (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Nov 2013 04:26:12 -0500
Received: from hqemgate16.nvidia.com ([216.228.121.65]:2803 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750725Ab3KYJ0H (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Nov 2013 04:26:07 -0500
X-PGP-Universal: processed;
	by hqnvupgp08.nvidia.com on Mon, 25 Nov 2013 01:19:54 -0800
Message-ID: <529317AB.1050600@nvidia.com>
Date: Mon, 25 Nov 2013 18:26:03 +0900
From: Alex Courbot <acourbot@nvidia.com>
Organization: NVIDIA
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
        Alexandre Courbot <gnurou@gmail.com>
CC: Linus Walleij <linus.walleij@linaro.org>,
        Stephen Warren <swarren@wwwdotorg.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: add missing declarations
References: <1385186069-28986-1-git-send-email-acourbot@nvidia.com> <20131125085831.GO2281@intel.com> <CAAVeFu+wFAqroiyzwRQLkRAmhVQV-efOYA51DTHUwMMA1nTYxA@mail.gmail.com> <20131125092802.GQ2281@intel.com>
In-Reply-To: <20131125092802.GQ2281@intel.com>
X-NVConfidentiality: public
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/25/2013 06:28 PM, Mika Westerberg wrote:
> On Mon, Nov 25, 2013 at 06:07:10PM +0900, Alexandre Courbot wrote:
>> On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg
>> <mika.westerberg@linux.intel.com> wrote:
>>> On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote:
>>>> Add missing declarations and include files to avoid warnings during
>>>> compilation of include/gpio/driver.h.
>>>
>>> It would be good to have those warnings included in the changelog as well.
>>
>> As in, copy-pasting the compiler's output? Isn't the change explicit enough?
>
> If you just do 'git log' you can't see the change itself and that's where
> the changelog should help. If I see some warnings when I build the kernel,
> the first thing I usually do is to check 'git log' against linux-next and
> see if someone has already fixed that warning (grepping the warning message
> from changelog).

Ah, I can see several examples of what you mention indeed. Will add 
these and send a v2.