From: <Srinivas_G_Gowda@Dell.com>
To: <tcminyard@gmail.com>, <linux-kernel@vger.kernel.org>,
<openipmi@mvista.com>
Subject: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd
Date: Mon, 25 Nov 2013 15:21:09 +0530 [thread overview]
Message-ID: <52931C2D.4070908@dell.com> (raw)
Setting up mod_timer() for IPMI_READ_EVENT_MSG_BUFFER_CMD.
Driver stalls in case we hit error cases for IPMI_READ_EVENT_MSG_BUFFER_CMD.
Signed-off-by: Srinivas Gowda <srinivas_g_gowda@dell.com>
---
drivers/char/ipmi/ipmi_si_intf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 15e4a60..affcc52 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -843,6 +843,9 @@ static enum si_sm_result smi_event_handler(struct smi_info *smi_info,
smi_info->curr_msg->data[1] = IPMI_READ_EVENT_MSG_BUFFER_CMD;
smi_info->curr_msg->data_size = 2;
+ smi_info->last_timeout_jiffies = jiffies;
+ mod_timer(&smi_info->si_timer, (jiffies + SI_TIMEOUT_JIFFIES));
+
smi_info->handlers->start_transaction(
smi_info->si_sm,
smi_info->curr_msg->data,
--
1.8.1.2
next reply other threads:[~2013-11-25 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 9:51 Srinivas_G_Gowda [this message]
2013-11-26 17:26 ` [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd Corey Minyard
[not found] ` <75F7F7632819D94BA80703D8B1F10B6D29CEE95A1D@BLRX7MCDC201.AMER.DELL.COM>
2013-11-30 0:19 ` Corey Minyard
2013-12-02 14:49 ` Srinivas_G_Gowda
2013-12-02 21:03 ` Corey Minyard
2013-12-03 6:18 ` Srinivas_G_Gowda
2013-12-03 17:10 ` Corey Minyard
2013-12-04 11:58 ` Srinivas_G_Gowda
2013-12-05 12:40 ` Srinivas_G_Gowda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52931C2D.4070908@dell.com \
--to=srinivas_g_gowda@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi@mvista.com \
--cc=tcminyard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox