From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753885Ab3KYMmz (ORCPT ); Mon, 25 Nov 2013 07:42:55 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:44713 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682Ab3KYMmu (ORCPT ); Mon, 25 Nov 2013 07:42:50 -0500 Message-ID: <52934589.3000502@ti.com> Date: Mon, 25 Nov 2013 14:41:45 +0200 From: "ivan.khoronzhuk" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Mark Rutland CC: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Santosh Shilimkar , "wim@iguana.be" , "nsekhar@ti.com" , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , Pawel Moll , "swarren@wwwdotorg.org" , "ijc+devicetree@hellion.org.uk" , "galak@kernel.crashing.org" , "rob.herring@calxeda.com" , "linux-kernel@vger.kernel.org" , "grant.likely@linaro.org" Subject: Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property References: <1383680783-12114-8-git-send-email-ivan.khoronzhuk@ti.com> <527A28E8.4010204@ti.com> <201311231857.47104.arnd@arndb.de> <52932DA1.8040204@ti.com> <20131125121529.GE32081@e106331-lin.cambridge.arm.com> In-Reply-To: <20131125121529.GE32081@e106331-lin.cambridge.arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.145.122] X-EXCLAIMER-MD-CONFIG: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2013 02:15 PM, Mark Rutland wrote: > On Mon, Nov 25, 2013 at 10:59:45AM +0000, ivan.khoronzhuk wrote: >> On 11/23/2013 07:57 PM, Arnd Bergmann wrote: >>> On Wednesday 06 November 2013, ivan.khoronzhuk wrote: >>>> @@ -7,6 +7,10 @@ Required properties: >>>> >>>> - reg : Should contain WDT registers location and length >>>> >>>> +- clocks: phandle reference to the controller clock. >>>> + Required only for Keystone arch. >>>> + See clock-bindings.txt >>>> + >>>> Optional properties: >>>> >>>> - timeout-sec: Contains the watchdog timeout in seconds >>> >>> I think it should really be listed under "Optional properties" and the >>> reference to Keystone removed. Note how the binding would need >>> to change otherwise if another platform started to use the clock, which >>> is a little silly. >>> >>> Arnd >>> >> >> Ok, I'll move clocks property under "Optional properties" and describe it >> as following: >> >> Optional properties: >> - timeout-sec : Contains the watchdog timeout in seconds >> - clocks: phandle reference to the controller clock. >> Needed if platform uses clocks. >> See clock-bindings.txt > > Nit: clocks aren't just phandles, they have a clock-specifier too (which > might be 0 cells). > > Otherwise this looks fine to me. > > Mark. > ... I will replace it to: Optional properties: - timeout-sec : Contains the watchdog timeout in seconds - clocks: the clock feeding the watchdog timer. Needed if platform uses clocks. See clock-bindings.txt Is it OK? -- Regards, Ivan Khoronzhuk