From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Stephen Warren <swarren@nvidia.com>,
Tomasz Figa <t.figa@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] pinctrl: provide documentation pointer
Date: Mon, 25 Nov 2013 10:17:58 -0700 [thread overview]
Message-ID: <52938646.6030306@wwwdotorg.org> (raw)
In-Reply-To: <1385390706-28722-1-git-send-email-linus.walleij@linaro.org>
On 11/25/2013 07:45 AM, Linus Walleij wrote:
> The PIN_CONFIG_OUTPUT parameter is really tricky to understand
> and needs an explicit pointer to the documentation.
> diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h
> * @PIN_CONFIG_OUTPUT: this will configure the pin in output, use argument
Well, while you're touching that...
s/in/as an/ s/, use/. Use/
> - * 1 to indicate high level, argument 0 to indicate low level.
> + * 1 to indicate high level, argument 0 to indicate low level. (Please
> + * Documentation/pinctrl.txt, section "GPIO mode pitfalls" for a
Add "see" to the start of that line.
> + * discussion around this parameter.)
(no need to resend to fix that, from my side at least)
prev parent reply other threads:[~2013-11-25 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 14:45 [PATCH] pinctrl: provide documentation pointer Linus Walleij
2013-11-25 17:17 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52938646.6030306@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox