From: Roberto Sassu <roberto.sassu@polito.it>
To: James Morris <jmorris@namei.org>, Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-security-module <linux-security-module@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] ima: bug fixes for Linus
Date: Mon, 25 Nov 2013 19:46:06 +0100 [thread overview]
Message-ID: <52939AEE.5070809@polito.it> (raw)
In-Reply-To: <alpine.LRH.2.02.1311260235020.9714@tundra.namei.org>
On 11/25/2013 04:40 PM, James Morris wrote:
> On Mon, 25 Nov 2013, Mimi Zohar wrote:
>
>> Hi James,
>>
>> These are the "essential fixes for regressions".
>>
>> The following changes since commit 4c1cc40a2d49500d84038ff751bc6cd183e729b5:
>>
>> Revert "KEYS: verify a certificate is signed by a 'trusted' key" (2013-11-23 16:38:17 -0800)
>>
>> are available in the git repository at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity for-linus
>>
>> for you to fetch changes up to 72ca1bd303a5126d0ce377cff699282b6b38bd86:
>>
>> ima: make a copy of template_fmt in template_desc_init_fields() (2013-11-25 07:32:46 -0500)
>>
>> thanks,
>>
>> Mimi
>>
>> ----------------------------------------------------------------
>> Roberto Sassu (3):
>
>> ima: make a copy of template_fmt in template_desc_init_fields()
>
>
>> template_desc_init_fields(char *template_fmt,
>
> That should probably be const char.
>
> Also, the call to kstrdup() results in a memory leak.
>
Hi James
thanks for the comments. I'm implementing them and I will post
a new version of the patch 'ima: make a copy of template_fmt in
template_desc_init_fields()' shortly.
Roberto Sassu
>
>
>
>
next prev parent reply other threads:[~2013-11-25 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 18:40 [GIT PULL] ima: bug fixes for Linus Mimi Zohar
2013-11-24 15:21 ` Mimi Zohar
2013-11-24 22:44 ` James Morris
2013-11-25 0:14 ` Mimi Zohar
2013-11-25 2:14 ` James Morris
2013-11-25 12:03 ` Mimi Zohar
2013-11-25 13:51 ` Mimi Zohar
2013-11-25 15:40 ` James Morris
2013-11-25 18:46 ` Roberto Sassu [this message]
2013-11-25 18:55 ` Roberto Sassu
2013-11-27 12:11 ` Sebastian Ott
2013-11-27 12:46 ` Roberto Sassu
2013-11-27 13:40 ` [PATCH] ima: store address of template_fmt_copy in a pointer before calling strsep Roberto Sassu
2013-11-27 14:55 ` Mimi Zohar
2013-11-27 15:01 ` Sebastian Ott
2013-11-25 20:33 ` [GIT PULL v3] ima: bug fixes for Linus Mimi Zohar
2013-11-25 20:54 ` Shuah Khan
2013-11-25 21:32 ` Mimi Zohar
2013-11-25 19:18 ` [PATCH] ima: make a copy of template_fmt in template_desc_init_fields() Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52939AEE.5070809@polito.it \
--to=roberto.sassu@polito.it \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox