From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752823Ab3KYVaf (ORCPT ); Mon, 25 Nov 2013 16:30:35 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:50271 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235Ab3KYVac (ORCPT ); Mon, 25 Nov 2013 16:30:32 -0500 Message-ID: <5293C16D.80605@ti.com> Date: Mon, 25 Nov 2013 15:30:21 -0600 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Viresh Kumar , CC: , , , , , , , Subject: Re: [PATCH V2 1/2] cpufreq: suspend governors on system suspend/hibernate References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/2013 05:29 AM, Viresh Kumar wrote: > This patch adds cpufreq callbacks to dpm_{suspend|resume}_noirq() for handling > suspend/resume of cpufreq governors. This is required for early suspend and late > resume of governors. > > There are multiple problems that are fixed by this patch: > - Nishanth Menon (TI) found an interesting problem on his platform, OMAP. His board > wasn't working well with suspend/resume as calls for removing non-boot CPUs > was turning out into a call to drivers ->target() which then tries to play > with regulators. But regulators and their I2C bus were already suspended and > this resulted in a failure. This is why we need a PM notifier here. > - Lan Tianyu (Intel) & Jinhyuk Choi (Broadcom) found another issue where > tunables configuration for clusters/sockets with non-boot CPUs was getting > lost after suspend/resume, as we were notifying governors with > CPUFREQ_GOV_POLICY_EXIT on removal of the last cpu for that policy and so > deallocating memory for tunables. > > Reported-by: Lan Tianyu > Reported-by: Nishanth Menon > Reported-by: Jinhyuk Choi > Signed-off-by: Viresh Kumar > --- > drivers/base/power/main.c | 3 +++ > drivers/cpufreq/cpufreq.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/cpufreq.h | 3 +++ > 3 files changed, 68 insertions(+) yes, this seems to work for me as well. http://pastebin.mozilla.org/3670909 - no cpufreq attempts to transition were triggered. -- Regards, Nishanth Menon