From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753002Ab3KZEKG (ORCPT ); Mon, 25 Nov 2013 23:10:06 -0500 Received: from mail-pd0-f181.google.com ([209.85.192.181]:39253 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879Ab3KZEKC (ORCPT ); Mon, 25 Nov 2013 23:10:02 -0500 Message-ID: <52941F14.2050900@gmail.com> Date: Tue, 26 Nov 2013 12:09:56 +0800 From: Peng Tao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: linux-kernel@vger.kernel.org, JC Lafoucriere , Andreas Dilger Subject: Re: [PATCH 08/16] staging/lustre/mdt: HSM coordinator agent interface References: <1385431510-18988-1-git-send-email-bergwolf@gmail.com> <1385431510-18988-9-git-send-email-bergwolf@gmail.com> <20131126033012.GA30128@kroah.com> In-Reply-To: <20131126033012.GA30128@kroah.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/26/2013 11:30 AM, Greg Kroah-Hartman wrote: > On Tue, Nov 26, 2013 at 10:05:02AM +0800, Peng Tao wrote: >> From: JC Lafoucriere >> >> To move data with external storage, HSM coordinator >> uses a Copy Tool running on a client named agent. >> This patch implements the interface for these agents. > > Interesting text here... > >> Lustre-change: http://review.whamcloud.com/6534 >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3342 >> Signed-off-by: JC Lafoucriere >> Reviewed-by: Jinshan Xiong >> Reviewed-by: Andreas Dilger >> Reviewed-by: John L. Hammond >> Reviewed-by: Oleg Drokin >> Signed-off-by: Peng Tao >> Signed-off-by: Andreas Dilger >> --- >> .../lustre/lustre/include/lustre/lustre_user.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h >> index 9436166..631f026 100644 >> --- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h >> +++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h >> @@ -428,8 +428,8 @@ struct obd_uuid { >> char uuid[UUID_MAX]; >> }; >> >> -static inline int obd_uuid_equals(const struct obd_uuid *u1, >> - const struct obd_uuid *u2) >> +static inline bool obd_uuid_equals(const struct obd_uuid *u1, >> + const struct obd_uuid *u2) >> { >> return strcmp((char *)u1->uuid, (char *)u2->uuid) == 0; >> } >> @@ -446,7 +446,7 @@ static inline void obd_str2uuid(struct obd_uuid *uuid, const char *tmp) >> } >> >> /* For printf's only, make sure uuid is terminated */ >> -static inline char *obd_uuid2str(struct obd_uuid *uuid) >> +static inline char *obd_uuid2str(const struct obd_uuid *uuid) >> { >> if (uuid->uuid[sizeof(*uuid) - 1] != '\0') { >> /* Obviously not safe, but for printfs, no real harm done... > > Too bad it doesn't describe the changes made in the code at all. > > How can so many people review a patch that is not the same as what it > says it really is? > The main part of the original commit is dropped as it only touches server code. I should have modified the commit message to say what exactly the patch does rather than just copying the original commit message. I'll fix up. Sorry. > I'm stopping here in the series, sorry. Please fix up and resend the > rest when you can. > Will do. Thanks for reviewing! Thanks, Tao