From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755684Ab3KZKR1 (ORCPT ); Tue, 26 Nov 2013 05:17:27 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:59175 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753907Ab3KZKRY (ORCPT ); Tue, 26 Nov 2013 05:17:24 -0500 Message-ID: <529474FA.9080103@ti.com> Date: Tue, 26 Nov 2013 15:46:26 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Matt Porter , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , Christian Daudt , Paul Zimmerman CC: Tomasz Figa , Kamil Debski , Kyungmin Park , Linux USB List , Linux ARM Kernel List , Linux Kernel Mailing List , Devicetree List , Linaro Patches Subject: Re: [PATCH v3 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls References: <1385403367-18144-1-git-send-email-matt.porter@linaro.org> <1385403367-18144-2-git-send-email-matt.porter@linaro.org> In-Reply-To: <1385403367-18144-2-git-send-email-matt.porter@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday 25 November 2013 11:45 PM, Matt Porter wrote: > This adds a pair of APIs that allows the generic PHY subsystem to > provide information on the PHY bus width. The PHY provider driver may > use phy_set_bus_width() to set the bus width that the PHY supports. > The controller driver may then use phy_get_bus_width() to fetch the > PHY bus width in order to properly configure the controller. > > Signed-off-by: Matt Porter > --- > include/linux/phy/phy.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index 6d72269..6ca6c61 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -46,6 +46,7 @@ struct phy_ops { > * @mutex: mutex to protect phy_ops > * @init_count: used to protect when the PHY is used by multiple consumers > * @power_count: used to protect when the PHY is used by multiple consumers > + * @bus_width: used to specify data width of the PHY bus > */ > struct phy { > struct device dev; > @@ -55,6 +56,7 @@ struct phy { > struct mutex mutex; > int init_count; > int power_count; > + int bus_width; the bus_width can be part of the attrs struct which you initially proposed. Soon there will be requests for other attributes being added (e.g., speed). > }; > > /** > @@ -127,6 +129,14 @@ int phy_init(struct phy *phy); > int phy_exit(struct phy *phy); > int phy_power_on(struct phy *phy); > int phy_power_off(struct phy *phy); > +static inline int phy_get_bus_width(struct phy *phy) > +{ > + return phy->bus_width; > +} > +static inline void phy_set_bus_width(struct phy *phy, int bus_width) u32 bus_width? > +{ > + phy->bus_width = bus_width; > +} > struct phy *phy_get(struct device *dev, const char *string); > struct phy *devm_phy_get(struct device *dev, const char *string); > void phy_put(struct phy *phy); > @@ -199,6 +209,16 @@ static inline int phy_power_off(struct phy *phy) > return -ENOSYS; > } > > +static inline int phy_get_bus_width(struct phy *phy) > +{ > + return -ENOSYS; > +} > + > +static inline void phy_set_bus_width(struct phy *phy, bus_width) er.. has this been compile tested? Thanks Kishon