From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: s5m-rtc: Fix info->rtc assignment
Date: Tue, 26 Nov 2013 12:16:32 +0100 [thread overview]
Message-ID: <52948310.9080409@samsung.com> (raw)
In-Reply-To: <5294673B.4050608@samsung.com>
On 11/26/2013 10:17 AM, Krzysztof Kozlowski wrote:
> On 11/15/2013 12:54 PM, Geert Uytterhoeven wrote:
>> drivers/rtc/rtc-s5m.c: In function ‘s5m_rtc_probe’:
>> drivers/rtc/rtc-s5m.c:545: warning: assignment from incompatible
>> pointer type
>>
>> struct s5m_rtc_info.rtc has type "struct regmap *", while
>> struct sec_pmic_dev.rtc has type "struct i2c_client *".
>>
>> Probably the author wanted to assign "struct sec_pmic_dev.regmap", which
>> has the correct type.
>>
>> Also, as "rtc" doesn't make much sense as a name for a regmap, rename
>> it to
>> "regmap".
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>> I would be really surprised if this driver didn't just crash...
>> Please test. Thanks!
>>
>> drivers/rtc/rtc-s5m.c | 54
>> ++++++++++++++++++++++++-------------------------
>> 1 file changed, 27 insertions(+), 27 deletions(-)
>
> Seems good, tested on device with S5M8767.
>
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Arrrg, the fix is needed but not sufficient. The chip has different I2C
addresses for RTC and PMIC so additional regmap is needed. Currently
this rtc-s5m driver does not work. I'll send patches fixing it.
Best regards,
Krzysztof
prev parent reply other threads:[~2013-11-26 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 11:54 [PATCH] rtc: s5m-rtc: Fix info->rtc assignment Geert Uytterhoeven
2013-11-26 9:17 ` Krzysztof Kozlowski
2013-11-26 11:16 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52948310.9080409@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sachin.kamat@linaro.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox