From: Dave Anderson <anderson@redhat.com>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
gthelen@google.com
Subject: Re: mm: Export 'pageflag_names' array
Date: Tue, 8 Oct 2013 14:37:21 -0400 (EDT) [thread overview]
Message-ID: <529498789.2966198.1381257441670.JavaMail.root@redhat.com> (raw)
In-Reply-To: <CAOMFOmUXxZNCTcoYOu_-aLPWUQ10jNoa3dDb4RUs2DCmGHqfKQ@mail.gmail.com>
----- Original Message -----
> Hi
>
> On Tue, Oct 8, 2013 at 5:40 AM, Dave Anderson <anderson@redhat.com> wrote:
> >
> >
> > ----- Original Message -----
> >> Hi Anatol,
> >>
> >> On Mon, Oct 07, 2013 at 10:53:32AM -0700, Anatol Pomozov wrote:
> >> > Hi Wu
> >> >
> >> > I have a request wrt your old commit 718a38211.
> >> >
> >> > I think it makes sense to export array pageflag_names so kernel dump
> >> > debug tools (like 'crash') can use it as well. Currently the tool
> >> > hard-codes flag names but it is suboptimal as flags are different for
> >> > different configs.
> >> >
> >> > What do you think? (I can send a patch if you are ok).
> >>
> >> I wonder if the KPF_* defined in
> >>
> >> include/uapi/linux/kernel-page-flags.h
> >>
> >> fit your needs. These are kernel page flags exported to the user space
> >> and will be maintained stable and immune to kconfig changes. You can
> >> find use examples of them in
> >>
> >> fs/proc/page.c
> >> tools/vm/page-types.c
> >>
> >> Thanks,
> >> Fengguang
> >>
> >
> > Nothing is required for the crash utility. The pageflag_names array (as well
> > as the pageflags enumerator) are readily available in the kernel debuginfo data.
>
> D'oh. You are right Dave. Everyone, please ignore my original question
> I mislooked this variable in symbols map (or maybe looked at an old
> kernel map).
>
> Dave, do you think 'crash' should use pageflag_names to output flag names?
It's a good addition -- I'm working on a patch as we speak...
Thanks,
Dave
prev parent reply other threads:[~2013-10-08 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 17:53 mm: Export 'pageflag_names' array Anatol Pomozov
2013-10-08 8:06 ` Fengguang Wu
2013-10-08 12:40 ` Dave Anderson
2013-10-08 18:28 ` Anatol Pomozov
2013-10-08 18:37 ` Dave Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529498789.2966198.1381257441670.JavaMail.root@redhat.com \
--to=anderson@redhat.com \
--cc=anatol.pomozov@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).