From: Guenter Roeck <linux@roeck-us.net>
To: Doug Anderson <dianders@chromium.org>, Wim Van Sebroeck <wim@iguana.be>
Cc: Fabio Porcedda <fabio.porcedda@gmail.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] watchdog: core: Make dt "timeout-sec" property work on drivers w/out min/max
Date: Tue, 26 Nov 2013 10:58:32 -0800 [thread overview]
Message-ID: <5294EF58.7040905@roeck-us.net> (raw)
In-Reply-To: <1385490173-7511-1-git-send-email-dianders@chromium.org>
On 11/26/2013 10:22 AM, Doug Anderson wrote:
> It is valid for a watchdog driver to have 0 for a "min" and "max"
> timeout if the driver doesn't need the core to enforce the concepts of
> min and max. The s3c2410_wdt driver is one such driver. Specifically
> it can be hard for that driver to come up with a static "max" on all
> platforms without a lot more information since the input clock on
> S3C2410 and S3C2440 can change with DVFS.
>
> As written, watchdog_init_timeout() will not ever read "timeout-sec"
> on these drivers since watchdog_timeout_invalid() will _never_ return
> true. Change to not consider a timeout_parm of 0 as valid even if
> min/max aren't specified by the driver. Also handle the case when
> there is no min/max and no "timeout-sec" property.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Makes sense to me.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
prev parent reply other threads:[~2013-11-26 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 18:22 [PATCH 1/2] watchdog: core: Make dt "timeout-sec" property work on drivers w/out min/max Doug Anderson
2013-11-26 18:22 ` [PATCH 2/2] watchdog: core: Fix watchdog_init_timeout() when invalid param / valid dt Doug Anderson
2013-11-26 18:58 ` Guenter Roeck
2013-11-26 19:23 ` Doug Anderson
2013-11-26 19:51 ` Guenter Roeck
2013-11-26 18:58 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5294EF58.7040905@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dianders@chromium.org \
--cc=fabio.porcedda@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox