From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754594AbcFTOGa (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jun 2016 10:06:30 -0400
Received: from mailout3.samsung.com ([203.254.224.33]:49721 "EHLO
	mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754038AbcFTOGG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jun 2016 10:06:06 -0400
X-AuditID: cbfee61a-f79106d000000835-53-5767f5b0db98
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        "linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
        linux-clk@vger.kernel.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] clk: samsung: cpu: prepare for adding Exynos5433 CPU
 clocks
Date: Mon, 20 Jun 2016 15:54:53 +0200
Message-id: <5297672.nIMnaEh2jc@amdc1976>
User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <CA+Ln22FwQ_e5OHg_8WHEWGER=X8g_Yq+NpVLONgb0ZAShJLjzA@mail.gmail.com>
References: <1464095957-25851-1-git-send-email-b.zolnierkie@samsung.com>
 <1464095957-25851-3-git-send-email-b.zolnierkie@samsung.com>
 <CA+Ln22FwQ_e5OHg_8WHEWGER=X8g_Yq+NpVLONgb0ZAShJLjzA@mail.gmail.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t9jQd0NX9PDDQ78VbR4/cLQov/xa2aL
	TY+vsVp87LnHanF51xw2ixnn9zFZXDzlanH4TTurxY8z3SwWq3b9YXTg8nh/o5Xd43JfL5PH
	zll32T02repk89i8pN6jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4Mo79XMpW8IKjYtffT0wN
	jJ3sXYycHBICJhLHpl9hgbDFJC7cW8/WxcjFISQwi1Fi+8wzUM5XRonXU3cxglSxCVhJTGxf
	BWaLCKhLfJvSzw5SxCywnFni09G3bCAJYYEwiSmTToCtYBFQlejfuJkZxOYV0JT4fmETE4gt
	KuAl0bP9EdggToFgiU3nOpkgtp1jlGjfshOqQVDix+R7YPcxC8hL7Ns/lRXC1pJYv/M40wRG
	oEMRymYhKZuFpGwBI/MqRonUguSC4qT0XMO81HK94sTc4tK8dL3k/NxNjODoeCa1g/HgLvdD
	jAIcjEo8vBM2pIcLsSaWFVfmHmKU4GBWEuGt/QgU4k1JrKxKLcqPLyrNSS0+xCjNwaIkzvv4
	/7owIYH0xJLU7NTUgtQimCwTB6dUA2P5pmSFZvY19mfEzer+muZ1fPV7eVjV+uezKRHnLl3n
	7k//k2YzxXjmyvb2g7c/ij/Vm+e5oyYgzHnpoc/H75dLPvvz7JCq89e1wdU2R5zb3XZkePl2
	754cHHCA+4nu0X3ztjx6tDzxxbcb7mtS37L6aefmryv96WEzjWFLQv4BngcHvGfs4FVRYinO
	SDTUYi4qTgQAd6FUrooCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Saturday, June 18, 2016 11:53:36 PM Tomasz Figa wrote:
> Hi Bart,

Hi Tomek,

> 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Exynos5433 uses different register layout for CPU clock registers
> > than earlier SoCs so add new code for handling this layout.  Also
> > add new CLK_CPU_HAS_E5433_REGS_LAYOUT flag to request using it.
> 
> Have you considered abstracting this? Comparing existing code with

Yes, I have considered abstracting this but I've decided that there is
sufficient number of differences to justify adding new code.

> newly added one, the differences don't really seem to be that huge and
> it looks like there is more common code than different, except maybe
> some numeric constants that could be put into a struct.

It is not only that, HPM clock sourcing checking would also need to be
abstracted somehow.  Anyway there is not a lot of new code and it so
much easier to follow by not being shared that I would prefer to keep
it that way.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics