From: David Ahern <dsahern@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Namhyung Kim <namhyung@kernel.org>,
Mike Galbraith <efault@gmx.de>,
Adrian Hunter <adrian.hunter@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCHv3 3/7] perf tools: Fine tune readn function
Date: Thu, 28 Nov 2013 09:03:45 -0700 [thread overview]
Message-ID: <52976961.2010609@gmail.com> (raw)
In-Reply-To: <20131128154350.GB31444@krava.brq.redhat.com>
On 11/28/13, 8:43 AM, Jiri Olsa wrote:
> - if (ret <= 0)
> + if ((ret <= 0) && (errno != EINTR))
> return ret;
I think you want:
if (ret < 0 && errno == EINTR)
continue;
if (ret <= 0)
return ret;
You certainly do not want ret < 0 here: ;-)
>
> - n -= ret;
> - buf += ret;
> + left -= ret;
> + buf += ret;
> }
>
> - return buf - buf_start;
> + BUG_ON((size_t)(buf - buf_start) != n);
> + return n;
> }
>
> size_t hex_width(u64 v)
>
next prev parent reply other threads:[~2013-11-28 16:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 10:30 [PATCHv2 0/7] perf tools: Add data file write interface Jiri Olsa
2013-11-28 10:30 ` [PATCH 1/7] perf record: Unify data output code into perf_record__write function Jiri Olsa
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 2/7] perf tools: Use correct return type for readn function Jiri Olsa
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 3/7] perf tools: Fine tune " Jiri Olsa
2013-11-28 15:19 ` David Ahern
2013-11-28 15:43 ` [PATCHv3 " Jiri Olsa
2013-11-28 16:03 ` David Ahern [this message]
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 4/7] perf tools: Add writen function Jiri Olsa
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 5/7] perf tools: Add perf_data_file__write interface Jiri Olsa
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 6/7] perf record: Use perf_data_file__write for output file Jiri Olsa
2013-11-28 14:03 ` Arnaldo Carvalho de Melo
2013-11-28 15:21 ` [PATCHv3 " Jiri Olsa
2013-11-28 10:30 ` [PATCH 7/7] perf inject: Handle output file via perf_data_file object Jiri Olsa
2013-11-28 14:14 ` Arnaldo Carvalho de Melo
2013-11-28 15:30 ` Jiri Olsa
2013-11-28 10:36 ` [PATCHv2 0/7] perf tools: Add data file write interface Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52976961.2010609@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox