From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942Ab3K2Czh (ORCPT ); Thu, 28 Nov 2013 21:55:37 -0500 Received: from mail-pd0-f175.google.com ([209.85.192.175]:54021 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753469Ab3K2CzK (ORCPT ); Thu, 28 Nov 2013 21:55:10 -0500 Message-ID: <52980290.6090001@gmail.com> Date: Fri, 29 Nov 2013 10:57:20 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Richard Kuo CC: linux-hexagon@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] arch: hexagon: kernel: hexagon_ksyms.c remove useless __hexagon_*i3() References: <5297FC23.3030507@gmail.com> In-Reply-To: <5297FC23.3030507@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/2013 10:29 AM, Chen Gang wrote: > Only find "DECLARE_EXPORT(__hexagon_*i3)", no related implementations > and callers, so remove them, or will cause ld issue with allmodconfig, > the related error: > > LD init/built-in.o > arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_umodsi3+0x0): undefined reference to `__hexagon_umodsi3' > arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_udivsi3+0x0): undefined reference to `__hexagon_udivsi3' > arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_modsi3+0x0): undefined reference to `__hexagon_modsi3' > arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_divsi3+0x0): undefined reference to `__hexagon_divsi3' > Oh, sorry, this patch need improved, we can not only remove them simply (although really no related callers and implementations), I will send patch v2 later when finish allmodconfig. Thanks. > > Signed-off-by: Chen Gang > --- > arch/hexagon/kernel/hexagon_ksyms.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/arch/hexagon/kernel/hexagon_ksyms.c b/arch/hexagon/kernel/hexagon_ksyms.c > index 32b1379..1257c85 100644 > --- a/arch/hexagon/kernel/hexagon_ksyms.c > +++ b/arch/hexagon/kernel/hexagon_ksyms.c > @@ -33,8 +33,3 @@ EXPORT_SYMBOL(memset); > > /* Symbols found in libgcc that assorted kernel modules need */ > DECLARE_EXPORT(__hexagon_memcpy_likely_aligned_min32bytes_mult8bytes); > - > -DECLARE_EXPORT(__hexagon_divsi3); > -DECLARE_EXPORT(__hexagon_modsi3); > -DECLARE_EXPORT(__hexagon_udivsi3); > -DECLARE_EXPORT(__hexagon_umodsi3); > -- Chen Gang