From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751769Ab3K2Gkj (ORCPT ); Fri, 29 Nov 2013 01:40:39 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:28203 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898Ab3K2Gkh (ORCPT ); Fri, 29 Nov 2013 01:40:37 -0500 Message-ID: <529836CD.1080900@huawei.com> Date: Fri, 29 Nov 2013 14:40:13 +0800 From: Libo Chen User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Serge Hallyn CC: , LKML , , David Miller , Li Zefan , Huang Qiang , Wengmeiling , "zhangwei(Jovi)" Subject: Re: Q: use vlan in container References: <5296E003.80804@huawei.com> <20131129050549.GB8830@sergelap> In-Reply-To: <20131129050549.GB8830@sergelap> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.72.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2013/11/29 13:05, Serge Hallyn wrote: > Quoting Libo Chen (clbchenlibo.chen@huawei.com): >> Hello LXC experts, >> >> I meet a problem. When using vlan as network device in suse11 system container, >> I can not use halt to stop this container. It hung on "eth0 is still used from interfaces eth0" in cycle. >> >> The config file: >> >> lxc.network.type = vlan >> lxc.network.flags = up >> lxc.network.link = eth0 >> lxc.network.name = eth0 >> lxc.network.vlan.id = 1301 >> lxc.network.ipv4 = 128.5.131.100/24 >> >> >> The reason is in the shell command /sbin/ifdown, see below: >> >> ###################################################################### >> # Shut down depending interfaces >> # >> # Check if there are interfaces which depend on this interface. If yes these >> # have to be shut down first. >> # For example these might be bonding or vlan interfaces. Note that we don't >> # catch all types of depending interfaces currently. See function >> # 'get_depending_ifaces' in file 'functions' for details. >> # >> test "$SCRIPTNAME" = ifdown && DEP_IFACES=`get_depending_ifaces $INTERFACE` >> if [ "$?" = 0 -a "$NODEPS" != yes ] ; then >> message "`printf " %-9s is still used from interfaces %s" \ >> $INTERFACE "$DEP_IFACES"`" >> for DI in $DEP_IFACES; do > > Should the proper fix be to fix this script so that it doesn't call > ifdown recursively if $DI = $INTERFACE ? Hi Serge, yes, I had try this way before as below: for DI in $DEP_IFACES; do if [ "$DI" != "$INTERFACE" ] ; then ifdown $DI -o $OPTIONS fi done It works well, but I have no idea it is safe enough and no side effects? Thanks, Libo > >> ifdown $DI -o $OPTIONS >> done >> >> message "`printf " %-9s now going down itself" $INTERFACE`" >> # check if iface is (still) avaliable >> # [bonding master may go down itself >> # while the last slave gets removed] >> if ! is_iface_available $INTERFACE; then >> exit $R_SUCCESS >> fi >> fi >> >> >> $DEP_IFACES is also eth0 in this scene, so ifdown will call ifdown again and again. >> >> if we set lxc.network.name = eth1, it will be ok, so can we add a judgment to make >> lxc.network.link and lxc.network.name are not equal in lxc-start command. >> >> simple implement like: >> >> if [ lxc.network.type == vlan ] ; then >> if [ lxc.network.link == lxc.network.name ] ; then >> return false >> fi >> fi >> >> >> Is it reasonable? or any other way to achieve this? >> >> >> > > . >