From: Levente Kurusa <levex@linux.com>
To: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, EDAC <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: mcheck: call put_device on device_register failure
Date: Fri, 29 Nov 2013 21:28:48 +0100 [thread overview]
Message-ID: <5298F900.9000208@linux.com> (raw)
This patch adds a call to put_device() when the device_register()
call has failed. This is required so that the last reference to the
device is given up.
Signed-off-by: Levente Kurusa <levex@linux.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index b3218cd..a389c1d 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2272,8 +2272,10 @@ static int mce_device_create(unsigned int cpu)
dev->release = &mce_device_release;
err = device_register(dev);
- if (err)
+ if (err) {
+ put_device(dev);
return err;
+ }
for (i = 0; mce_device_attrs[i]; i++) {
err = device_create_file(dev, mce_device_attrs[i]);
--
1.8.1.2
next reply other threads:[~2013-11-29 20:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 20:28 Levente Kurusa [this message]
2013-11-29 20:56 ` [PATCH] x86: mcheck: call put_device on device_register failure Borislav Petkov
2013-11-30 7:30 ` Levente Kurusa
2013-11-30 11:12 ` Borislav Petkov
2013-11-30 11:25 ` Levente Kurusa
2013-11-30 11:32 ` Borislav Petkov
2013-11-30 11:44 ` Levente Kurusa
2013-11-30 12:08 ` Borislav Petkov
2013-11-30 12:37 ` Levente Kurusa
2013-12-03 2:23 ` Chen, Gong
2013-12-03 17:01 ` Borislav Petkov
2013-12-04 7:38 ` Chen, Gong
2013-12-04 18:39 ` Levente Kurusa
2013-12-05 2:57 ` Chen, Gong
2013-12-05 11:18 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5298F900.9000208@linux.com \
--to=levex@linux.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox