From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238Ab3LATnT (ORCPT ); Sun, 1 Dec 2013 14:43:19 -0500 Received: from mail.active-venture.com ([67.228.131.205]:58984 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024Ab3LATnP (ORCPT ); Sun, 1 Dec 2013 14:43:15 -0500 X-Originating-IP: 108.223.40.66 Message-ID: <529B9152.9090106@roeck-us.net> Date: Sun, 01 Dec 2013 11:43:14 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Christophe Leroy , Wim Van Sebroeck , scottwood@freescale.com CC: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] watchdog: mpc8xxx_wdt: MPC8xx is HW enabled References: <20131130154540.E83D743E15@localhost.localdomain> In-Reply-To: <20131130154540.E83D743E15@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/2013 07:45 AM, Christophe Leroy wrote: > MPC8xx watchdog is enabled at startup by HW. > If the bootloader disables it, it cannot be reenabled. > Is that true for all variants of 8xx, especially for 823 ? I am a bit concerned about breaking compatibility with some chips ... assuming there was a reason for not setting this flag originally. Thanks, Guenter > Signed-off-by: Christophe Leroy > > diff -ur a/drivers/watchdog/mpc8xxx_wdt.c b/drivers/watchdog/mpc8xxx_wdt.c > --- a/drivers/watchdog/mpc8xxx_wdt.c 2013-05-11 22:57:46.000000000 +0200 > +++ b/drivers/watchdog/mpc8xxx_wdt.c 2013-08-08 02:12:15.000000000 +0200 > @@ -273,6 +310,7 @@ > .compatible = "fsl,mpc823-wdt", > .data = &(struct mpc8xxx_wdt_type) { > .prescaler = 0x800, > + .hw_enabled = true, > }, > }, > {}, > > --- > Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce que la protection avast! Antivirus est active. > http://www.avast.com > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >