From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag
Date: Mon, 02 Dec 2013 09:57:23 +0800 [thread overview]
Message-ID: <529BE903.1020408@gtsys.com.hk> (raw)
In-Reply-To: <529A2026.4050605@cogentembedded.com>
Hi
On Sunday, December 01, 2013 01:28 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 30-11-2013 7:51, Chris Ruehl wrote:
>
>> usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag
>
>> * init the sts flag to 0 (missed)
>> * Set PORTCS_STS only if VUSB_HS_PHY_TYPE > 1
>> otherwise the register is ReadOnly
>> * Set/Reset correct BIT(28)/BIT(29) for STS
>
>> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
>
> The coding style is still wrong at places...
>
..
>> - hw_write(ci, OP_DEVLC, DEVLC_STS, sts);
>> + if ( sts )
>
> Remove spaces around 'sts', please.
...
>> + portsc = (ioread32(ci->hw_bank.regmap[OP_PORTSC])
>> + & PORTSC_STS);
>
> No need for outer (). And it's preferred that an operator is left at the
> end of a first line, not starts the continuation line.
>
> WBR, Sergei
>
Sergei,
Thanks, I will take care of and have a question about style
portsc = ioread32(ci->hw_bank.regmap[OP_PORTSC] & PORTSC_STS;
the line in the if/else alignment extent the 80char barrier and should be
splitted in this case '&' is at 81 .. how serious I should follow this one?
portsc = ioread32(ci->hw_bank.regmap[OP_PORTSC] &
PORTSC_STS;
I keep this mail private don't want make too much noise on the list.
regards
Chris
prev parent reply other threads:[~2013-12-02 1:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 3:51 [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag Chris Ruehl
2013-11-30 10:20 ` Peter Chen
2013-12-02 1:49 ` Chris Ruehl
2013-12-02 5:10 ` Peter Chen
2013-12-02 5:17 ` Chris Ruehl
2013-11-30 17:28 ` Sergei Shtylyov
2013-12-02 1:57 ` Chris Ruehl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529BE903.1020408@gtsys.com.hk \
--to=chris.ruehl@gtsys.com.hk \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox