* Re: [PATCH] perf Makefile: Correct the message in feature-libnuma checking.
2013-12-02 14:11 ` [PATCH] perf Makefile: Correct the message in feature-libnuma checking Dongsheng Yang
@ 2013-12-02 1:33 ` Peter Hurley
2013-12-02 14:49 ` Dongsheng Yang
0 siblings, 1 reply; 8+ messages in thread
From: Peter Hurley @ 2013-12-02 1:33 UTC (permalink / raw)
To: Dongsheng Yang, Arnaldo Carvalho de Melo; +Cc: linux-kernel
On 12/02/2013 09:11 AM, Dongsheng Yang wrote:
> ccing linux-kernel@vger.kernel.org
>
> On 11/29/2013 01:14 PM, Arnaldo Carvalho de Melo wrote:
>> Em Fri, Nov 29, 2013 at 04:05:52PM -0500, Dongsheng Yang escreveu:
>>> The package required for numa is named numactl-devel in Fedora and RHEL and
>>> libnuma-devel in OpenSuSE. This patch correct the package name in warning
>>> message.
and libnuma-dev in Ubuntu.
>> Applying, but please always CC linux-kernel@vger.kernel.org, so that
>> others can review it as well.
>
> Okey!!
>
> Thanx Arnaldo.
>>
>> - Arnaldo
>>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>>> ---
>>> tools/perf/config/Makefile | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
>>> index 80ea6d8..2e615d8 100644
>>> --- a/tools/perf/config/Makefile
>>> +++ b/tools/perf/config/Makefile
>>> @@ -537,7 +537,7 @@ endif
>>> ifndef NO_LIBNUMA
>>> ifeq ($(feature-libnuma), 0)
>>> - msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numa-libs-devel or libnuma-dev);
>>> + msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numactl-devel or libnuma-devel);
>>> NO_LIBNUMA := 1
>>> else
>>> CFLAGS += -DHAVE_LIBNUMA_SUPPORT
>>> --
>>> 1.8.2.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] perf Makefile: Correct the message in feature-libnuma checking.
2013-12-02 15:26 ` [PATCH V2] " Dongsheng Yang
@ 2013-12-02 2:31 ` Peter Hurley
2013-12-02 12:26 ` Arnaldo Carvalho de Melo
2013-12-04 15:41 ` [tip:perf/core] perf tools: " tip-bot for Dongsheng Yang
1 sibling, 1 reply; 8+ messages in thread
From: Peter Hurley @ 2013-12-02 2:31 UTC (permalink / raw)
To: Dongsheng Yang, acme; +Cc: linux-kernel
On 12/02/2013 10:26 AM, Dongsheng Yang wrote:
> The package required for numa is named numactl-devel in Fedora or RHEL,
> and libnuma-devel in OpenSuSE, and libnuma-dev in Ubuntu. This patch
> corrects the package name in warning message in feature-libnuma checking.
Thanks (and thanks for correcting the other lib names).
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] perf Makefile: Correct the message in feature-libnuma checking.
2013-12-02 2:31 ` Peter Hurley
@ 2013-12-02 12:26 ` Arnaldo Carvalho de Melo
2013-12-02 12:45 ` Peter Hurley
0 siblings, 1 reply; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-12-02 12:26 UTC (permalink / raw)
To: Peter Hurley; +Cc: Dongsheng Yang, linux-kernel
Em Sun, Dec 01, 2013 at 09:31:28PM -0500, Peter Hurley escreveu:
> On 12/02/2013 10:26 AM, Dongsheng Yang wrote:
> >The package required for numa is named numactl-devel in Fedora or RHEL,
> >and libnuma-devel in OpenSuSE, and libnuma-dev in Ubuntu. This patch
> >corrects the package name in warning message in feature-libnuma checking.
>
> Thanks (and thanks for correcting the other lib names).
I'll take this as an:
Acked-by: Peter Hurley <peter@hurleysoftware.com>
Ok?
Please read Documentation/SubmittingPatches, relevant part:
------------------------------------------------------------
13) When to use Acked-by: and Cc:
The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.
If a person was not directly involved in the preparation or handling of a
patch but wishes to signify and record their approval of it then they can
arrange to have an Acked-by: line added to the patch's changelog.
Acked-by: is often used by the maintainer of the affected code when that
maintainer neither contributed to nor forwarded the patch.
Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
has at least reviewed the patch and has indicated acceptance. Hence patch
mergers will sometimes manually convert an acker's "yep, looks good to me"
into an Acked-by:.
Acked-by: does not necessarily indicate acknowledgement of the entire patch.
For example, if a patch affects multiple subsystems and has an Acked-by: from
one subsystem maintainer then this usually indicates acknowledgement of just
the part which affects that maintainer's code. Judgement should be used here.
When in doubt people should refer to the original discussion in the mailing
list archives.
If a person has had the opportunity to comment on a patch, but has not
provided such comments, you may optionally add a "Cc:" tag to the patch.
This is the only tag which might be added without an explicit action by the
person it names. This tag documents that potentially interested parties
have been included in the discussion
------------------------------------------------------------
Thanks,
- Arnaldo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] perf Makefile: Correct the message in feature-libnuma checking.
2013-12-02 12:26 ` Arnaldo Carvalho de Melo
@ 2013-12-02 12:45 ` Peter Hurley
0 siblings, 0 replies; 8+ messages in thread
From: Peter Hurley @ 2013-12-02 12:45 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: Dongsheng Yang, linux-kernel
On 12/02/2013 07:26 AM, Arnaldo Carvalho de Melo wrote:
> Em Sun, Dec 01, 2013 at 09:31:28PM -0500, Peter Hurley escreveu:
>> On 12/02/2013 10:26 AM, Dongsheng Yang wrote:
>>> The package required for numa is named numactl-devel in Fedora or RHEL,
>>> and libnuma-devel in OpenSuSE, and libnuma-dev in Ubuntu. This patch
>>> corrects the package name in warning message in feature-libnuma checking.
>>
>> Thanks (and thanks for correcting the other lib names).
>
> I'll take this as an:
>
> Acked-by: Peter Hurley <peter@hurleysoftware.com>
>
> Ok?
Yes, ok.
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf Makefile: Correct the message in feature-libnuma checking.
[not found] ` <20131129181417.GA9876@ghostprotocols.net>
@ 2013-12-02 14:11 ` Dongsheng Yang
2013-12-02 1:33 ` Peter Hurley
0 siblings, 1 reply; 8+ messages in thread
From: Dongsheng Yang @ 2013-12-02 14:11 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: linux-kernel
ccing linux-kernel@vger.kernel.org
On 11/29/2013 01:14 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Nov 29, 2013 at 04:05:52PM -0500, Dongsheng Yang escreveu:
>> The package required for numa is named numactl-devel in Fedora and RHEL and
>> libnuma-devel in OpenSuSE. This patch correct the package name in warning
>> message.
> Applying, but please always CC linux-kernel@vger.kernel.org, so that
> others can review it as well.
Okey!!
Thanx Arnaldo.
>
> - Arnaldo
>
>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>> ---
>> tools/perf/config/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
>> index 80ea6d8..2e615d8 100644
>> --- a/tools/perf/config/Makefile
>> +++ b/tools/perf/config/Makefile
>> @@ -537,7 +537,7 @@ endif
>>
>> ifndef NO_LIBNUMA
>> ifeq ($(feature-libnuma), 0)
>> - msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numa-libs-devel or libnuma-dev);
>> + msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numactl-devel or libnuma-devel);
>> NO_LIBNUMA := 1
>> else
>> CFLAGS += -DHAVE_LIBNUMA_SUPPORT
>> --
>> 1.8.2.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf Makefile: Correct the message in feature-libnuma checking.
2013-12-02 1:33 ` Peter Hurley
@ 2013-12-02 14:49 ` Dongsheng Yang
2013-12-02 15:26 ` [PATCH V2] " Dongsheng Yang
0 siblings, 1 reply; 8+ messages in thread
From: Dongsheng Yang @ 2013-12-02 14:49 UTC (permalink / raw)
To: Peter Hurley; +Cc: Arnaldo Carvalho de Melo, linux-kernel
On 12/01/2013 08:33 PM, Peter Hurley wrote:
> On 12/02/2013 09:11 AM, Dongsheng Yang wrote:
>> ccing linux-kernel@vger.kernel.org
>>
>> On 11/29/2013 01:14 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Fri, Nov 29, 2013 at 04:05:52PM -0500, Dongsheng Yang escreveu:
>>>> The package required for numa is named numactl-devel in Fedora and
>>>> RHEL and
>>>> libnuma-devel in OpenSuSE. This patch correct the package name in
>>>> warning
>>>> message.
>
> and libnuma-dev in Ubuntu.
>
Right, I will send v2 with 'numactl-devel/libnuma-dev/libnuma-devel'.
Thanx Peter.
>>> Applying, but please always CC linux-kernel@vger.kernel.org, so that
>>> others can review it as well.
>>
>> Okey!!
>>
>> Thanx Arnaldo.
>>>
>>> - Arnaldo
>>>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>>>> ---
>>>> tools/perf/config/Makefile | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
>>>> index 80ea6d8..2e615d8 100644
>>>> --- a/tools/perf/config/Makefile
>>>> +++ b/tools/perf/config/Makefile
>>>> @@ -537,7 +537,7 @@ endif
>>>> ifndef NO_LIBNUMA
>>>> ifeq ($(feature-libnuma), 0)
>>>> - msg := $(warning No numa.h found, disables 'perf bench numa
>>>> mem' benchmark, please install numa-libs-devel or libnuma-dev);
>>>> + msg := $(warning No numa.h found, disables 'perf bench numa
>>>> mem' benchmark, please install numactl-devel or libnuma-devel);
>>>> NO_LIBNUMA := 1
>>>> else
>>>> CFLAGS += -DHAVE_LIBNUMA_SUPPORT
>>>> --
>>>> 1.8.2.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2] perf Makefile: Correct the message in feature-libnuma checking.
2013-12-02 14:49 ` Dongsheng Yang
@ 2013-12-02 15:26 ` Dongsheng Yang
2013-12-02 2:31 ` Peter Hurley
2013-12-04 15:41 ` [tip:perf/core] perf tools: " tip-bot for Dongsheng Yang
0 siblings, 2 replies; 8+ messages in thread
From: Dongsheng Yang @ 2013-12-02 15:26 UTC (permalink / raw)
To: peter, acme; +Cc: linux-kernel, Dongsheng Yang
The package required for numa is named numactl-devel in Fedora or RHEL,
and libnuma-devel in OpenSuSE, and libnuma-dev in Ubuntu. This patch
corrects the package name in warning message in feature-libnuma checking.
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
---
Changes since v1
- Add libnuma-dev for Ubuntu.
tools/perf/config/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 80ea6d8..acd3684 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -537,7 +537,7 @@ endif
ifndef NO_LIBNUMA
ifeq ($(feature-libnuma), 0)
- msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numa-libs-devel or libnuma-dev);
+ msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numactl-devel/libnuma-devel/libnuma-dev);
NO_LIBNUMA := 1
else
CFLAGS += -DHAVE_LIBNUMA_SUPPORT
--
1.8.2.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [tip:perf/core] perf tools: Correct the message in feature-libnuma checking.
2013-12-02 15:26 ` [PATCH V2] " Dongsheng Yang
2013-12-02 2:31 ` Peter Hurley
@ 2013-12-04 15:41 ` tip-bot for Dongsheng Yang
1 sibling, 0 replies; 8+ messages in thread
From: tip-bot for Dongsheng Yang @ 2013-12-04 15:41 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, hpa, mingo, peter, tglx, yangds.fnst
Commit-ID: 6305edfc4079668ce02e360a6e5aeea88b9dd279
Gitweb: http://git.kernel.org/tip/6305edfc4079668ce02e360a6e5aeea88b9dd279
Author: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
AuthorDate: Mon, 2 Dec 2013 10:26:48 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 2 Dec 2013 09:26:39 -0300
perf tools: Correct the message in feature-libnuma checking.
The package required for numa is named numactl-devel in Fedora or RHEL,
and libnuma-devel in OpenSuSE, and libnuma-dev in Ubuntu.
This patch corrects the package name in warning message in
feature-libnuma checking.
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Acked-by: Peter Hurley <peter@hurleysoftware.com>
Cc: Peter Hurley <peter@hurleysoftware.com>
Link: http://lkml.kernel.org/r/1385998008-6851-1-git-send-email-yangds.fnst@cn.fujitsu.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index f7d11a8..36e66ac 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -533,7 +533,7 @@ endif
ifndef NO_LIBNUMA
ifeq ($(feature-libnuma), 0)
- msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numa-libs-devel or libnuma-dev);
+ msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numactl-devel/libnuma-devel/libnuma-dev);
NO_LIBNUMA := 1
else
CFLAGS += -DHAVE_LIBNUMA_SUPPORT
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-12-04 15:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1385759152-19752-1-git-send-email-yangds.fnst@cn.fujitsu.com>
[not found] ` <20131129181417.GA9876@ghostprotocols.net>
2013-12-02 14:11 ` [PATCH] perf Makefile: Correct the message in feature-libnuma checking Dongsheng Yang
2013-12-02 1:33 ` Peter Hurley
2013-12-02 14:49 ` Dongsheng Yang
2013-12-02 15:26 ` [PATCH V2] " Dongsheng Yang
2013-12-02 2:31 ` Peter Hurley
2013-12-02 12:26 ` Arnaldo Carvalho de Melo
2013-12-02 12:45 ` Peter Hurley
2013-12-04 15:41 ` [tip:perf/core] perf tools: " tip-bot for Dongsheng Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox