From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>,
acme@ghostprotocols.net, Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mike Galbraith <efault@gmx.de>, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 1/2] perf sched: Introduce timehist command - v2
Date: Mon, 02 Dec 2013 07:28:30 -0700 [thread overview]
Message-ID: <529C990E.8000303@gmail.com> (raw)
In-Reply-To: <871u1vptty.fsf@sejong.aot.lge.com>
On 12/2/13, 12:58 AM, Namhyung Kim wrote:
>> time cpu task name[tid/pid] b/n time sch delay run time
>> ------------- ---- -------------------- --------- --------- ---------
>> 79371.874569 [11] gcc[31949] 0.014 0.000 1.148
>> 79371.874591 [10] gcc[31951] 0.000 0.000 0.024
>> 79371.874603 [10] migration/10[59] 3.350 0.004 0.011
>> 79371.874604 [11] <idle> 1.148 0.000 0.035
>> 79371.874723 [05] <idle> 0.016 0.000 1.383
>> 79371.874746 [05] gcc[31949] 0.153 0.078 0.022
>> ...
>>
>> Times are in msec.usec.
>
> Hmm.. I'm not sure this is right. It probably confuse users since
> timehist_time_str() still uses "sec.usec" format and it looks not
> natural for me to use "msec".
>
> Yeah, I see perf stat uses "msec.usec" for result of clock events but
> AFAICT it also shows the unit explicitly. And perf stat -I uses
> "sec.nsec" format and perf script also uses "sec.usec" format so there's
> a little consistency here.
>
> I think this "msec.usec" format fits well for the scheduling events but
> in general "sec.usec" format looks better IMHO.
Arnaldo / Ingo: any thoughts on the units here? sec.usec versus msec.usec?
David
next prev parent reply other threads:[~2013-12-02 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 0:23 [PATCH 0/2] perf: sched timehist command - v2 David Ahern
2013-12-02 0:23 ` [PATCH 1/2] perf sched: Introduce " David Ahern
2013-12-02 7:58 ` Namhyung Kim
2013-12-02 14:28 ` David Ahern [this message]
2013-12-02 9:33 ` Pekka Enberg
2013-12-02 14:33 ` David Ahern
2013-12-02 16:19 ` David Ahern
2013-12-02 0:23 ` [PATCH 2/2] perf sched: Add documentation for timehist options David Ahern
2013-12-02 6:07 ` Srikar Dronamraju
2013-12-02 12:38 ` Ingo Molnar
2013-12-02 7:41 ` Namhyung Kim
2013-12-02 14:37 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C990E.8000303@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox