public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Chris Ruehl <chris.ruehl@gtsys.com.hk>,
	balbi@ti.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] usb: phy-ulpi: Add EXTVBUSIND,CHRGVBUS flag support
Date: Mon, 02 Dec 2013 21:59:30 +0300	[thread overview]
Message-ID: <529CD892.5010601@cogentembedded.com> (raw)
In-Reply-To: <1385967919-13258-3-git-send-email-chris.ruehl@gtsys.com.hk>

On 12/02/2013 10:05 AM, Chris Ruehl wrote:

> usb: phy-ulpi: Add EXTVBUSIND,CHRGVBUS flag support

> ULPI like ISP1504 support external vbus power indication
> used in combination with vbus switches mic2075.

> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> ---
>   drivers/usb/phy/phy-ulpi.c |   11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)

> diff --git a/drivers/usb/phy/phy-ulpi.c b/drivers/usb/phy/phy-ulpi.c
> index 217339d..e2f15c4 100644
> --- a/drivers/usb/phy/phy-ulpi.c
> +++ b/drivers/usb/phy/phy-ulpi.c
> @@ -180,6 +180,8 @@ static int ulpi_init(struct usb_phy *phy)
>   	int i, vid, pid, ret;
>   	u32 ulpi_id = 0;
>
> +	pr_info("ULPI Viewport 0x%p\n",phy->io_priv);
> +

    You forgot space after comma.

WBR, Sergei


  reply	other threads:[~2013-12-02 17:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02  7:05 [PATCH] usb: phy-generic, phy-ulpi patch set Chris Ruehl
2013-12-02  7:05 ` [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect Chris Ruehl
2013-12-06 20:24   ` Felipe Balbi
2013-12-09  1:45     ` Chris Ruehl
2013-12-09  4:07       ` Felipe Balbi
2013-12-09  4:11         ` Chris Ruehl
2013-12-02  7:05 ` [PATCH 2/3] usb: phy-ulpi: Add EXTVBUSIND,CHRGVBUS flag support Chris Ruehl
2013-12-02 18:59   ` Sergei Shtylyov [this message]
2013-12-02  7:05 ` [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support Chris Ruehl
2013-12-02 18:22   ` Mark Rutland
2013-12-03  2:46     ` Chris Ruehl
2013-12-03  5:24     ` Chris Ruehl
2013-12-03  8:15   ` Heikki Krogerus
2013-12-04  7:16     ` Chris Ruehl
2013-12-04  9:49       ` Heikki Krogerus
2013-12-05  4:15         ` Chris Ruehl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529CD892.5010601@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=balbi@ti.com \
    --cc=chris.ruehl@gtsys.com.hk \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox