public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Milo Kim <milo.kim@ti.com>
To: Bryan Wu <cooloney@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	"Linux LED Subsystem" <linux-leds@vger.kernel.org>,
	"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH 2/3] leds: lp5521/5523: Remove duplicate mutex
Date: Tue, 3 Dec 2013 10:24:12 +0900	[thread overview]
Message-ID: <529D32BC.2020504@ti.com> (raw)
In-Reply-To: <CAK5ve-JEsBy6gd+oVwpnzkQe7eTmW6qkK-Rb4cM-JkKHPdiC9g@mail.gmail.com>

Hi Bryan,

On 12/03/2013 04:40 AM, Bryan Wu wrote:
> On Wed, Nov 20, 2013 at 10:14 PM, Milo Kim <milo.kim@ti.com> wrote:
>> It can be a problem when a pattern is loaded via the firmware interface.
>> LP55xx common driver has already locked the mutex in 'lp55xx_firmware_loaded()'.
>> So it should be deleted.
>>
>
> Looks like lp5521_update_program_memory() will be called by
> store_engine_load() without holding a lock after this change, is this
> correct? I think you need also update store_engine_load() to hold the
> lock when calling lp5521_update_program_memory().

Thanks, good point! I've just sent the patch-v2.

Best regards,
   Milo


      reply	other threads:[~2013-12-03  1:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  6:14 [PATCH 2/3] leds: lp5521/5523: Remove duplicate mutex Milo Kim
2013-12-02 19:40 ` Bryan Wu
2013-12-03  1:24   ` Milo Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529D32BC.2020504@ti.com \
    --to=milo.kim@ti.com \
    --cc=cooloney@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox