From: Laxman Dewangan <ldewangan@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants
Date: Tue, 3 Dec 2013 11:34:13 +0530 [thread overview]
Message-ID: <529D745D.2070503@nvidia.com> (raw)
In-Reply-To: <20131202142522.GA17566@ulmo.nvidia.com>
On Monday 02 December 2013 07:55 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Dec 02, 2013 at 07:25:01PM +0530, Laxman Dewangan wrote:
>
> +
> +/* Schmitt enable/disable */
> +#define TEGRA_PIN_DRIVE_SCHMITT_DISABLE 0
> +#define TEGRA_PIN_DRIVE_SCHMITT_ENABLE 1
> These are all boolean, so I wonder if perhaps we should be simply
> defining a single pair and reuse that in different contexts:
>
> #define TEGRA_PIN_DISABLE 0
> #define TEGRA_PIN_ENABLE 1
>
> The property names should provide enough context for them to be used
> unambiguously.
>
>
I can make generic ENABLE/DISABLE macro as you suggested but datasheet
says as 0=NORMAL, 1 = TRISTATE. and that's why I kept name very near to
the datasheet.
Thanks,
Laxman
next prev parent reply other threads:[~2013-12-03 6:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 13:55 [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants Laxman Dewangan
2013-12-02 13:55 ` [PATCH 2/2] ARM: tegra: convert device tree file of Dalmore to use pinctrl defines Laxman Dewangan
2013-12-03 20:09 ` Stephen Warren
2013-12-04 5:51 ` Laxman Dewangan
2013-12-04 16:59 ` Stephen Warren
2013-12-02 14:25 ` [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants Thierry Reding
2013-12-03 6:04 ` Laxman Dewangan [this message]
2013-12-03 20:08 ` Stephen Warren
2013-12-04 5:49 ` Laxman Dewangan
2013-12-03 20:05 ` Stephen Warren
2013-12-03 20:06 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529D745D.2070503@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox