Re: [PATCH 3/4] Regulators: TPS65218: Add Regulator driver for TPS65218 PMIC

Manish Badarkhe
2013-12-04T07:39:23Z

Hi Keerthy,

> + rdev = regulator_register(&regulators[id], &config);

Can you make use of "devm_regulator_register" instead?

> + if (IS_ERR(rdev)) {
> + dev_err(tps->dev, "failed to register %s regulator\n",
> + pdev->name);
> + return PTR_ERR(rdev);
> + }
> +
> + /* Save regulator */
> + tps->rdev[id] = rdev;
> +
> + return 0;
> +}

Best Regards
Manish Badarkhe