From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753417Ab3LCKw6 (ORCPT ); Tue, 3 Dec 2013 05:52:58 -0500 Received: from rtits2.realtek.com ([60.250.210.242]:47950 "EHLO rtits2.realtek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753325Ab3LCKws (ORCPT ); Tue, 3 Dec 2013 05:52:48 -0500 X-SpamFilter-By: BOX Solutions SpamTrap 5.38 with qID rB3AqVSO014533, This message is accepted by code: ctloc85258 Message-ID: <529DB86D.3010002@realsil.com.cn> Date: Tue, 3 Dec 2013 18:54:37 +0800 From: micky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Lee Jones CC: , , , , , Subject: Re: [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings References: <932dcc03570ceb86316272d4eba7f4207d001def.1386051860.git.micky_ching@realsil.com.cn> <20131203104003.GJ11828@lee--X1> In-Reply-To: <20131203104003.GJ11828@lee--X1> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [172.29.41.103] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2013 06:40 PM, Lee Jones wrote: > This should contain the author's name. > > You should use: > `git rebase -i` /* Use edit option */ > then > `git commit --amend --author="First Last " > > To apply it. > Sorry Lee, I will modify it. Is the order important? or only your name is need here? >> drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings': >> drivers/mfd/rtl8411.c:58:7: warning: 'reg1' is used uninitialized in this function [-Wuninitialized] >> drivers/mfd/rtl8411.c: In function 'rtl8411b_fetch_vendor_settings': >> drivers/mfd/rtl8411.c:79:7: warning: 'reg' is used uninitialized in this function [-Wuninitialized] >> drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings': >> drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this function [-Wuninitialized] >> >> Signed-off-by: Lee Jones >> Tested-by: Micky Ching > I know this is a bit of a strange situation, but whenever you sent > patches to the MLs, you need to sign it off yourself too. > > Did you mean I need write like this ? Signed-off-by: Lee Jones Tested-by: Micky Ching Signed-off-by: Micky Ching -- Best Regards Micky.