From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753183Ab3LCMYo (ORCPT ); Tue, 3 Dec 2013 07:24:44 -0500 Received: from smtp-out-012.synserver.de ([212.40.185.12]:1115 "EHLO smtp-out-110.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752837Ab3LCMYn (ORCPT ); Tue, 3 Dec 2013 07:24:43 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 25281 Message-ID: <529DCD8A.30600@metafoo.de> Date: Tue, 03 Dec 2013 13:24:42 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Lee Jones CC: alsa-devel@alsa-project.org, broonie@kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation References: <1386066427-6862-1-git-send-email-lee.jones@linaro.org> <529DC6BE.3080607@metafoo.de> <20131203120420.GC12031@lee--X1> <529DCB76.4070705@metafoo.de> In-Reply-To: <529DCB76.4070705@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2013 01:15 PM, Lars-Peter Clausen wrote: > On 12/03/2013 01:04 PM, Lee Jones wrote: >> On Tue, 03 Dec 2013, Lars-Peter Clausen wrote: >> >>> On 12/03/2013 11:27 AM, Lee Jones wrote: >>>> If booting with full DT support (i.e. DMA too, the last piece of the >>>> puzzle), then we don't need to use the compatible_request_channel call >>>> back or require some of the historical bumph which probably isn't >>>> required by a platform data start-up now either. This will also be >>>> ripped out in upcoming commits. >>>> >>>> Cc: alsa-devel@alsa-project.org >>>> Acked-by: Linus Walleij >>>> Signed-off-by: Lee Jones >>> >>> Strictly speaking you do not need the second config, but well considering >>> that this will all hopefully be removed soon anyway it should be fine. >> >> That's true it will, but why don't we need the second config? I won't >> want the compat function to be called in the DT case. > > It will only be called if it was not possible to request the DMA channel > from the DT. The logic used to request the channel is basically this (in pseudo code). chan = NULL. if (of_node && !(flags & NO_DT)) chan = dma_request_slave_channel(...) if (!chan && (flags & COMPAT)) chan = dma_request_channel(compat_filter_fn, compat_filter_data);