From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>,
Pekka Enberg <penberg@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH v2 2/3] perf tools: Record sampling time for each entry
Date: Tue, 03 Dec 2013 09:20:23 -0700 [thread overview]
Message-ID: <529E04C7.5090804@gmail.com> (raw)
In-Reply-To: <1386061229-19514-2-git-send-email-namhyung@kernel.org>
On 12/3/13, 2:00 AM, Namhyung Kim wrote:
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index 20a7c653b74b..ac65fc67972c 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -69,6 +69,7 @@ struct perf_evsel {
> struct hists hists;
> u64 first_timestamp;
> u64 last_timestamp;
> + u64 *prev_timestamps;
Why plural and why dynamically allocated? The allocation only does a
single u64, not an array.
David
next prev parent reply other threads:[~2013-12-03 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 9:00 [PATCH v2 1/3] perf tools: Record total sampling time Namhyung Kim
2013-12-03 9:00 ` [PATCH v2 2/3] perf tools: Record sampling time for each entry Namhyung Kim
2013-12-03 16:20 ` David Ahern [this message]
2013-12-09 7:59 ` Namhyung Kim
2013-12-03 9:00 ` [PATCH v2 3/3] perf report: Add --event-time option Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E04C7.5090804@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox