From: Randy Dunlap <rdunlap@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Matthew Garrett <matthew.garrett@nebula.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove unnecessarily gendered language
Date: Tue, 03 Dec 2013 09:53:37 -0800 [thread overview]
Message-ID: <529E1AA1.9000202@infradead.org> (raw)
In-Reply-To: <CAMuHMdXcHTTmnqCTJWRJU_2vgv3wtB9gFGiR5Z0GF=BDKniXCg@mail.gmail.com>
On 12/03/13 01:04, Geert Uytterhoeven wrote:
> Disclaimer: didn't read through all of it.
>
> On Tue, Dec 3, 2013 at 2:18 AM, Matthew Garrett
> <matthew.garrett@nebula.com> wrote:
>> --- a/drivers/scsi/mesh.c
>> +++ b/drivers/scsi/mesh.c
>> @@ -1190,8 +1190,8 @@ static void handle_msgin(struct mesh_state *ms)
>> if (tp->sdtr_state != sdtr_sent) {
>> /* reply with an SDTR */
>> add_sdtr_msg(ms);
>> - /* limit period to at least his value,
>> - offset to no more than his */
>> + /* limit period to at least its value,
>> + offset to no more than its */
>> if (ms->msgout[3] < ms->msgin[3])
>> ms->msgout[3] = ms->msgin[3];
>> if (ms->msgout[4] > ms->msgin[4])
>
> I think both occurrences of "his" should actually be "this".
>
> BTW, the singular they ("The caller must know what they are doing!")
> feels a bit strange to me, but it seems to match the wikipedia article on
> singular they. As a non-native English speaker, I was not familiar with it.
I understand, since as a native English speaker I was not familiar with it either,
and I still don't like it. ;)
--
~Randy
next prev parent reply other threads:[~2013-12-03 17:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 1:18 [PATCH] Remove unnecessarily gendered language Matthew Garrett
2013-12-03 9:04 ` Geert Uytterhoeven
2013-12-03 17:53 ` Randy Dunlap [this message]
2013-12-04 2:36 ` Matthew Garrett
2013-12-05 10:48 ` Pavel Machek
2013-12-05 16:35 ` Matthew Garrett
2013-12-08 12:38 ` Pavel Machek
2013-12-09 19:09 ` Matthew Garrett
2013-12-10 7:56 ` Oliver Neukum
2013-12-05 16:54 ` One Thousand Gnomes
2013-12-05 17:41 ` Harald Arnesen
2013-12-08 12:47 ` Pavel Machek
2013-12-18 13:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E1AA1.9000202@infradead.org \
--to=rdunlap@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox