Re: [PATCH?] uprobes: change uprobe_write_opcode() to modify the page directly

H. Peter Anvin
2013-12-03T22:43:30Z

On 12/03/2013 12:54 PM, Oleg Nesterov wrote:
> On 12/03, H. Peter Anvin wrote:
>>
>> There is no architecture-independent way to make code globally visible.
>
> Then I probably misunderstood "globally". Or something else.
>
> So do you think the patch I sent is wrong? Why?
>

It is wrong in the sense that without an architecture-specific
synchronization at the end it is not guaranteed to work. It will work
fine on x86 and presumably any other architecture where icache-dcache
coherency is enforced in hardware (I am *guessing* that includes all or
most SMP platforms, but it is definitely *not* true on all UP platforms.)

-hpa