Re: [PATCH] perf vendor events: Make the power8/power9 event files valid JSON

Subho Banerjee
2019-11-19T03:21:13Z

Hi Arnaldo,
I am uncertain which commit you are working on.

The command that you sent fails on the latest commit of the master branch (af42d3466bdc8f39806b26f593604fdc54140bcb) on kernel/git/torvalds/linux.git.

Is there a more up to date version of the perf tools that I should be looking at instead of what is in the kernel repo?

ssbaner2@dvorak:~/linux$ git rev-parse --verify HEAD
af42d3466bdc8f39806b26f593604fdc54140bcb

ssbaner2@dvorak:~/linux$ diffstat -l -p1 0001-perf-vendor-events-Make-the-power8-power9-event-file.patch | while read filename ; do echo $filename ; cat $filename | json_verify ; done
tools/perf/pmu-events/arch/powerpc/power8/cache.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x4c0
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/floating-point.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x200
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/frontend.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x250
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/marked.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x351
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/memory.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x100
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/other.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x1f0
(right here) ------^
JSON is invalid

Regards,
Subho

> On Nov 18, 2019, at 9:18 PM, Subho Banerjee <ssbanerje@gmail.com> wrote:
>
> Hi Arnaldo,
> I am uncertain which commit you are working on.
>
> The command that you sent fails on the latest commit of the master branch (af42d3466bdc8f39806b26f593604fdc54140bcb) on kernel/git/torvalds/linux.git.
>
> Is there a more up to date version of the perf tools that I should be looking at instead of what is in the kernel repo?
>
> ssbaner2@dvorak:~/linux$ git rev-parse --verify HEAD
> af42d3466bdc8f39806b26f593604fdc54140bcb
>
>
> ssbaner2@dvorak:~/linux$ diffstat -l -p1 0001-perf-vendor-events-Make-the-power8-power9-event-file.patch | while read filename ; do echo $filename ; cat $filename | json_verify ; done
> tools/perf/pmu-events/arch/powerpc/power8/cache.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x4c0
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/floating-point.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x200
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/frontend.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x250
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/marked.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x351
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/memory.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x100
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/other.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x1f0
> (right here) ------^
> JSON is invalid
>
>
> Regards,
> Subho