public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Borislav Petkov <bp@alien8.de>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jingbai Ma <jingbai.ma@hp.com>,
	Jerry Hoemann <jerry.hoemann@hp.com>
Subject: Re: [PATCH v9] x86, apic, kexec, Documentation: Add disable_cpu_apic kernel parameter
Date: Wed, 04 Dec 2013 15:24:43 +0900	[thread overview]
Message-ID: <529ECAAB.8040309@jp.fujitsu.com> (raw)
In-Reply-To: <529E9CA6.5040200@jp.fujitsu.com>

(2013/12/04 12:08), HATAYAMA Daisuke wrote:
> (2013/12/04 0:25), Vivek Goyal wrote:
>> On Tue, Dec 03, 2013 at 10:32:26AM +0900, HATAYAMA Daisuke wrote:
>>
>> [..]
>>>
>>> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
>>> index 50680a5..dd77bec 100644
>>> --- a/Documentation/kernel-parameters.txt
>>> +++ b/Documentation/kernel-parameters.txt
>>> @@ -774,6 +774,15 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>>>       disable=    [IPV6]
>>>               See Documentation/networking/ipv6.txt.
>>>
>>> +    disable_cpu_apicid= [X86,APIC,KEXEC,SMP]
>>
>> Hi Hatayama,
>>
>> We are almost there. A minor nit. Why have we specified KEXEC here. This
>> parameter disabled_cpu_apicid does not seem to dependon CONFIG_KEXEC?
>>
>> Jerry, this patch looks good to me. Does it work on your system?
>>
>
> Because primary user for the option is currently kexec/kdump only.
>
> I referred to acpi_rsdp description:
>
>          acpi_rsdp=      [ACPI,EFI,KEXEC]
>                          Pass the RSDP address to the kernel, mostly used
>                          on machines running EFI runtime service to boot the
>                          second kernel for kdump.
>

Indo-san, who introduced acpi_rsdp and KEXEC tag, told me that historical reason
why KEXEC tag was introduced. disable_cpu_apicid is generic at least in the
current version, so the tag doesn't need to be specified here.

I'll post a new version soon.

-- 
Thanks.
HATAYAMA, Daisuke


  reply	other threads:[~2013-12-04  6:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03  1:32 [PATCH v9] x86, apic, kexec, Documentation: Add disable_cpu_apic kernel parameter HATAYAMA Daisuke
2013-12-03 15:25 ` Vivek Goyal
2013-12-04  3:08   ` HATAYAMA Daisuke
2013-12-04  6:24     ` HATAYAMA Daisuke [this message]
2013-12-04 17:36       ` Vivek Goyal
2013-12-04 20:21   ` Jerry.Hoemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529ECAAB.8040309@jp.fujitsu.com \
    --to=d.hatayama@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=ebiederm@xmission.com \
    --cc=fengguang.wu@intel.com \
    --cc=hpa@linux.intel.com \
    --cc=jerry.hoemann@hp.com \
    --cc=jingbai.ma@hp.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox