From: Qiao Zhou <zhouqiao@marvell.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "eric.y.miao@gmail.com" <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Chao Xie <cxie4@marvell.com>
Subject: Re: [PATCH 1/2] arm: mmp: build sram driver alone
Date: Wed, 4 Dec 2013 16:01:07 +0800 [thread overview]
Message-ID: <529EE143.80601@marvell.com> (raw)
In-Reply-To: <CAPcyv4iMFCmQVbqphkcuKTsMg-YzApyPM2DnO-JY3htLhnrMXg@mail.gmail.com>
On 12/04/2013 03:56 PM, Dan Williams wrote:
> On Tue, Dec 3, 2013 at 11:05 PM, Qiao Zhou <zhouqiao@marvell.com> wrote:
>> sram driver can be used by many chips besides CPU_MMP2, and so build
>> it alone.
>>
>> Reported-by: Dan Williams <dan.j.williams@intel.com>
>> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
>> ---
>> arch/arm/mach-mmp/Kconfig | 5 +++++
>> arch/arm/mach-mmp/Makefile | 3 ++-
>> 2 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
>> index ebdda83..6a6597c 100644
>> --- a/arch/arm/mach-mmp/Kconfig
>> +++ b/arch/arm/mach-mmp/Kconfig
>> @@ -136,4 +136,9 @@ config USB_EHCI_MV_U2O
>> help
>> Enables support for OTG controller which can be switched to host mode.
>>
>> +config MMP_SRAM
>> + bool
>> + help
>> + Select code specific to sram.
>> +
>
> No need for help text for something that is selected, and might as
> well squash this with patch 2.
>
Dan, thanks. I'll update it.
--
Best Regards
Qiao
next prev parent reply other threads:[~2013-12-04 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 7:05 [PATCH 1/2] arm: mmp: build sram driver alone Qiao Zhou
2013-12-04 7:05 ` [PATCH 2/2] dma: mmp-tdma: select sram driver Qiao Zhou
2013-12-04 7:56 ` [PATCH 1/2] arm: mmp: build sram driver alone Dan Williams
2013-12-04 8:01 ` Qiao Zhou [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-04 8:21 [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone Qiao Zhou
2013-12-04 8:21 ` [PATCH 1/2] arm: mmp: build sram driver alone Qiao Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529EE143.80601@marvell.com \
--to=zhouqiao@marvell.com \
--cc=cxie4@marvell.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox