From: Oliver Schinagl <oliver@schinagl.nl>
To: Tejun Heo <tj@kernel.org>
Cc: grant.likely@linaro.org,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dev@linux-sunxi.org,
maxime.ripard@free-electrons.com, ijc@hellion.org.uk,
hdegoede@redhat.com, oliver+list@schinagl.nl
Subject: Re: [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs
Date: Wed, 04 Dec 2013 13:56:23 +0100 [thread overview]
Message-ID: <529F2677.3070208@schinagl.nl> (raw)
In-Reply-To: <20131204123708.GD3158@htj.dyndns.org>
On 04-12-13 13:37, Tejun Heo wrote:
> On Wed, Dec 04, 2013 at 01:10:54PM +0100, oliver@schinagl.nl wrote:
>> From: Oliver Schinagl <oliver@schinagl.nl>
>>
>> This patch adds support for the sunxi series of SoC's by allwinner. It
>> plugs into the ahci-platform framework.
>>
>> Note: Currently it uses a somewhat hackish approach that probably needs
>> a lot more work, but does the same as the IMX SoC's.
>>
>> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
>> ---
>> .../devicetree/bindings/ata/ahci-sunxi.txt | 24 ++
>> drivers/ata/Kconfig | 9 +
>> drivers/ata/Makefile | 1 +
>> drivers/ata/ahci_platform.c | 12 +
>> drivers/ata/ahci_sunxi.c | 305 +++++++++++++++++++++
> I'm not really liking the way things are going. Do we really need
> separate drivers for each platform ahci implementation. Are they
> really that different? Would it be impossible to make ahci_platform
> generic enough so that we don't eventually end up with a gazillion
> ahci_XXX drivers?
I took the imx driver as example, as I wasn't sure on where to start.
But I don't think it's possible yet without improving ahci_platform as I
suggested in the cover letter. So if ahci_platform needs to be improved,
I guess a separate patch series would be more appropriate?
So would it be acceptable to have this as the 2nd (and last?)
ahci_platform driver and go from there? Or do you want to block new
ahci_XXX drivers until ahci_platform has been improved?
Oliver
>
next prev parent reply other threads:[~2013-12-04 12:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 12:10 [PATCH 0/3] AHCI: sunxi: Add sunxi AHCI driver oliver
2013-12-04 12:10 ` [PATCH 1/3] RFC: AHCI: libahci is missing DMA oliver
2013-12-04 12:32 ` Tejun Heo
2013-12-04 12:36 ` Oliver Schinagl
2013-12-04 12:47 ` Sergei Shtylyov
2013-12-04 13:09 ` Oliver Schinagl
2013-12-04 12:10 ` [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs oliver
2013-12-04 12:26 ` Mark Rutland
2013-12-04 12:49 ` Oliver Schinagl
2013-12-04 12:37 ` Tejun Heo
2013-12-04 12:56 ` Oliver Schinagl [this message]
2013-12-04 13:14 ` Tejun Heo
2013-12-04 13:16 ` Olliver Schinagl
2013-12-04 13:23 ` Tejun Heo
2013-12-06 9:01 ` Thomas Petazzoni
2013-12-06 9:12 ` Oliver Schinagl
2013-12-06 9:18 ` Thomas Petazzoni
2013-12-06 11:06 ` Hans de Goede
2013-12-15 19:00 ` Hans de Goede
2013-12-15 19:04 ` Tejun Heo
2013-12-16 6:21 ` Oliver Schinagl
2013-12-11 14:51 ` Olliver Schinagl
2013-12-12 6:40 ` Shawn Guo
2013-12-12 8:47 ` Olliver Schinagl
2013-12-04 12:10 ` [PATCH 3/3] ARM: sunxi: dts: Add ahci support to a few A10 and A20 boards oliver
2013-12-06 18:33 ` Maxime Ripard
2013-12-07 11:47 ` Olliver Schinagl
2013-12-07 13:11 ` [linux-sunxi] " Michal Suchanek
2013-12-09 19:16 ` Maxime Ripard
2013-12-04 12:14 ` [PATCH 0/3] AHCI: sunxi: Add sunxi AHCI driver Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F2677.3070208@schinagl.nl \
--to=oliver@schinagl.nl \
--cc=dev@linux-sunxi.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=hdegoede@redhat.com \
--cc=ijc@hellion.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=oliver+list@schinagl.nl \
--cc=rob.herring@calxeda.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox