* [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata()
@ 2013-12-03 6:50 Jingoo Han
2013-12-03 6:51 ` [PATCH 2/2] clocksource: sh_mtu2: " Jingoo Han
2013-12-04 14:54 ` [PATCH 1/2] clocksource: sh_tmu: " Daniel Lezcano
0 siblings, 2 replies; 6+ messages in thread
From: Jingoo Han @ 2013-12-03 6:50 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner', linux-kernel, 'Magnus Damm',
'Paul Mundt', 'Simon Horman',
'Laurent Pinchart', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/clocksource/sh_tmu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
index 63557cd..e29295e 100644
--- a/drivers/clocksource/sh_tmu.c
+++ b/drivers/clocksource/sh_tmu.c
@@ -523,7 +523,6 @@ static int sh_tmu_probe(struct platform_device *pdev)
ret = sh_tmu_setup(p, pdev);
if (ret) {
kfree(p);
- platform_set_drvdata(pdev, NULL);
pm_runtime_idle(&pdev->dev);
return ret;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] clocksource: sh_mtu2: remove unnecessary platform_set_drvdata()
2013-12-03 6:50 [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-12-03 6:51 ` Jingoo Han
2013-12-04 14:54 ` Daniel Lezcano
2013-12-04 14:54 ` [PATCH 1/2] clocksource: sh_tmu: " Daniel Lezcano
1 sibling, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2013-12-03 6:51 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner', linux-kernel, 'Magnus Damm',
'Paul Mundt', 'Simon Horman',
'Laurent Pinchart', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/clocksource/sh_mtu2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c
index 3cf1283..d8ed6e6 100644
--- a/drivers/clocksource/sh_mtu2.c
+++ b/drivers/clocksource/sh_mtu2.c
@@ -358,7 +358,6 @@ static int sh_mtu2_probe(struct platform_device *pdev)
ret = sh_mtu2_setup(p, pdev);
if (ret) {
kfree(p);
- platform_set_drvdata(pdev, NULL);
pm_runtime_idle(&pdev->dev);
return ret;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata()
2013-12-03 6:50 [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata() Jingoo Han
2013-12-03 6:51 ` [PATCH 2/2] clocksource: sh_mtu2: " Jingoo Han
@ 2013-12-04 14:54 ` Daniel Lezcano
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2013-12-04 14:54 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Thomas Gleixner', linux-kernel, 'Magnus Damm',
'Paul Mundt', 'Simon Horman',
'Laurent Pinchart'
On 12/03/2013 07:50 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
> ---
Applied to my tree for 3.14.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata()
@ 2013-08-21 9:21 Jingoo Han
2013-08-22 0:29 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2013-08-21 9:21 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner', linux-kernel, 'Magnus Damm',
'Paul Mundt', 'Simon Horman',
'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/clocksource/sh_tmu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
index 78b8dae..54ab475 100644
--- a/drivers/clocksource/sh_tmu.c
+++ b/drivers/clocksource/sh_tmu.c
@@ -509,7 +509,6 @@ static int sh_tmu_probe(struct platform_device *pdev)
ret = sh_tmu_setup(p, pdev);
if (ret) {
kfree(p);
- platform_set_drvdata(pdev, NULL);
pm_runtime_idle(&pdev->dev);
return ret;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata()
2013-08-21 9:21 Jingoo Han
@ 2013-08-22 0:29 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-08-22 0:29 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Daniel Lezcano', 'Thomas Gleixner', linux-kernel,
'Magnus Damm', 'Paul Mundt'
On Wed, Aug 21, 2013 at 06:21:29PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
No objections for this and the following patch:
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Daniel, let me know if you would prefer if I queued these up
and sent you a pull request or you would rather just pick
them up directly.
> ---
> drivers/clocksource/sh_tmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
> index 78b8dae..54ab475 100644
> --- a/drivers/clocksource/sh_tmu.c
> +++ b/drivers/clocksource/sh_tmu.c
> @@ -509,7 +509,6 @@ static int sh_tmu_probe(struct platform_device *pdev)
> ret = sh_tmu_setup(p, pdev);
> if (ret) {
> kfree(p);
> - platform_set_drvdata(pdev, NULL);
> pm_runtime_idle(&pdev->dev);
> return ret;
> }
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-04 14:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-03 6:50 [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata() Jingoo Han
2013-12-03 6:51 ` [PATCH 2/2] clocksource: sh_mtu2: " Jingoo Han
2013-12-04 14:54 ` Daniel Lezcano
2013-12-04 14:54 ` [PATCH 1/2] clocksource: sh_tmu: " Daniel Lezcano
-- strict thread matches above, loose matches on Subject: below --
2013-08-21 9:21 Jingoo Han
2013-08-22 0:29 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox