From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933376Ab3LEBhk (ORCPT ); Wed, 4 Dec 2013 20:37:40 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:28095 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756299Ab3LEBhg (ORCPT ); Wed, 4 Dec 2013 20:37:36 -0500 Message-ID: <529FD8D7.1020900@marvell.com> Date: Thu, 5 Dec 2013 09:37:27 +0800 From: Qiao Zhou User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Dan Williams CC: Haojian Zhuang , Miao Eric , Vinod Koul , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , Chao Xie Subject: Re: [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone References: <1386145275-27438-1-git-send-email-zhouqiao@marvell.com> <529F10D6.4000307@marvell.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.72,1.0.14,0.0.0000 definitions=2013-12-04_08:2013-12-05,2013-12-04,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1305240000 definitions=main-1312040208 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2013 03:17 AM, Dan Williams wrote: > On Wed, Dec 4, 2013 at 3:24 AM, Qiao Zhou wrote: >> On 12/04/2013 07:17 PM, Haojian Zhuang wrote: >>> >>> Dan indicated that you could pack these two patches into one. Whatever >>> it's also OK to use two patches. >> >> Misunderstood it... Thanks for correcting. >> > > Please combine the patches for two reasons: > 1/ patch1 by itself makes the problem worse it prevents the mmp_tdma > driver from building even if CPU_MMP2 is selected. > 2/ patch2 does not have a changelog and is the only user of the > enabling in patch1 > Dan, I updated the patch according to your suggestions. please help take a look again. Thanks. -- Best Regards Qiao