[PATCH 0/2 V1] arm-mmp-build-sram-driver-alone

[PATCH 0/2 V1] arm-mmp-build-sram-driver-alone

[Qiao Zhou]

V1 -> V0:
No need for help text for MMP_SRAM in Kconfig and move it into MMP_TDMA
text in Kconfig.

Qiao Zhou (2):
  arm: mmp: build sram driver alone
  dma: mmp-tdma: select sram driver

 arch/arm/mach-mmp/Kconfig  |    3 +++
 arch/arm/mach-mmp/Makefile |    3 ++-
 drivers/dma/Kconfig        |    2 ++
 3 files changed, 7 insertions(+), 1 deletions(-)

[PATCH 1/2] arm: mmp: build sram driver alone

[Qiao Zhou]

sram driver can be used by many chips besides CPU_MMP2, and so build
it alone.

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
 arch/arm/mach-mmp/Kconfig  |    3 +++
 arch/arm/mach-mmp/Makefile |    3 ++-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
index ebdda83..ebdba87 100644
--- a/arch/arm/mach-mmp/Kconfig
+++ b/arch/arm/mach-mmp/Kconfig
@@ -136,4 +136,7 @@ config USB_EHCI_MV_U2O
 	help
 	  Enables support for OTG controller which can be switched to host mode.
 
+config MMP_SRAM
+	bool
+
 endif
diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
index 9b702a1..98f0f63 100644
--- a/arch/arm/mach-mmp/Makefile
+++ b/arch/arm/mach-mmp/Makefile
@@ -7,7 +7,8 @@ obj-y				+= common.o devices.o time.o
 # SoC support
 obj-$(CONFIG_CPU_PXA168)	+= pxa168.o
 obj-$(CONFIG_CPU_PXA910)	+= pxa910.o
-obj-$(CONFIG_CPU_MMP2)		+= mmp2.o sram.o
+obj-$(CONFIG_CPU_MMP2)		+= mmp2.o
+obj-$(CONFIG_MMP_SRAM)		+= sram.o
 
 ifeq ($(CONFIG_COMMON_CLK), )
 obj-y				+= clock.o
-- 
1.7.0.4

[PATCH 2/2] dma: mmp-tdma: select sram driver

[Qiao Zhou]

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
 drivers/dma/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index dd2874e..599f0ae 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -288,9 +288,11 @@ config MMP_TDMA
 	bool "MMP Two-Channel DMA support"
 	depends on ARCH_MMP
 	select DMA_ENGINE
+	select MMP_SRAM
 	help
 	  Support the MMP Two-Channel DMA engine.
 	  This engine used for MMP Audio DMA and pxa910 SQU.
+	  It needs sram driver under mach-mmp.
 
 	  Say Y here if you enabled MMP ADMA, otherwise say N.
 
-- 
1.7.0.4

Re: [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone

[Haojian Zhuang]

On Wed, Dec 4, 2013 at 4:21 PM, Qiao Zhou <zhouqiao@marvell.com> wrote:
> V1 -> V0:
> No need for help text for MMP_SRAM in Kconfig and move it into MMP_TDMA
> text in Kconfig.
>
> Qiao Zhou (2):
>   arm: mmp: build sram driver alone
>   dma: mmp-tdma: select sram driver
>
>  arch/arm/mach-mmp/Kconfig  |    3 +++
>  arch/arm/mach-mmp/Makefile |    3 ++-
>  drivers/dma/Kconfig        |    2 ++
>  3 files changed, 7 insertions(+), 1 deletions(-)
>

Dan indicated that you could pack these two patches into one. Whatever
it's also OK to use two patches.

Applied.

Thanks
Haojian

Re: [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone

[Qiao Zhou]

On 12/04/2013 07:17 PM, Haojian Zhuang wrote:
> Dan indicated that you could pack these two patches into one. Whatever
> it's also OK to use two patches.
Misunderstood it... Thanks for correcting.

-- 

Best Regards
Qiao

Re: [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone

[Dan Williams]

On Wed, Dec 4, 2013 at 3:24 AM, Qiao Zhou <zhouqiao@marvell.com> wrote:
> On 12/04/2013 07:17 PM, Haojian Zhuang wrote:
>>
>> Dan indicated that you could pack these two patches into one. Whatever
>> it's also OK to use two patches.
>
> Misunderstood it... Thanks for correcting.
>

Please combine the patches for two reasons:
1/ patch1 by itself makes the problem worse it prevents the mmp_tdma
driver from building even if CPU_MMP2 is selected.
2/ patch2 does not have a changelog and is the only user of the
enabling in patch1

Re: [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone

[Qiao Zhou]

On 12/05/2013 03:17 AM, Dan Williams wrote:
> On Wed, Dec 4, 2013 at 3:24 AM, Qiao Zhou <zhouqiao@marvell.com> wrote:
>> On 12/04/2013 07:17 PM, Haojian Zhuang wrote:
>>>
>>> Dan indicated that you could pack these two patches into one. Whatever
>>> it's also OK to use two patches.
>>
>> Misunderstood it... Thanks for correcting.
>>
>
> Please combine the patches for two reasons:
> 1/ patch1 by itself makes the problem worse it prevents the mmp_tdma
> driver from building even if CPU_MMP2 is selected.
> 2/ patch2 does not have a changelog and is the only user of the
> enabling in patch1
>
Dan, I updated the patch according to your suggestions. please help take 
a look again. Thanks.

-- 

Best Regards
Qiao