From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755784Ab3LEXaM (ORCPT ); Thu, 5 Dec 2013 18:30:12 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:40492 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754095Ab3LEXaI (ORCPT ); Thu, 5 Dec 2013 18:30:08 -0500 Message-ID: <52A10C7B.8070406@wwwdotorg.org> Date: Thu, 05 Dec 2013 16:30:03 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Laxman Dewangan , linus.walleij@linaro.org, thierry.reding@gmail.com, Thierry Reding CC: rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, grant.likely@linaro.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ashwini Ghuge Subject: Re: [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124 References: <1386241070-4350-1-git-send-email-ldewangan@nvidia.com> <1386241070-4350-5-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1386241070-4350-5-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2013 03:57 AM, Laxman Dewangan wrote: > From: Ashwini Ghuge > > This adds a driver for the Tegra124 pinmux, and required > parameterization data for Tegra124. > > The driver uses the common Tegra pincontrol driver utility > functions to implement the majority of the driver. > > This driver is not compatible with the earlier NVIDIA's SoCs, > hence add new compatibile as "nvidia,tegra124-pinmux". > > Originally written by Ashwini Gguhe. > ldewangan: > - cleanup the patches, > - Fix address issue. IIRC, Thierry mentioned he had some fixes in his local branch for this driver. Thierry, can you please confirm/deny this? I made the following comment on the version Ashwini posted, which hasn't been addressed yet: A day or two ago during upstream review: >> +static const struct tegra_function tegra124_functions[] = { > ... >> + FUNCTION(i2c1), >> + FUNCTION(i2c2), >> + FUNCTION(i2c3), >> + FUNCTION(i2c4), >> + FUNCTION(i2cpwr), > > Is that complete? Tegra124 apparently has 6 I2C controllers. Are the > pins for the new sixth controller (0x7000d100) not affected by the pinmux? That said, if we find things are missing, I suppose we can add them later without breaking existing ABI. Breakage would only happen if we had to change/remove something. During downstream review quite a while ago I also said: >> > +static const struct pinctrl_pin_desc tegra124_pins[] = { >> >> There are two spaces before "tegra124_pins[]". >> >> > +static const char * const gmi_groups[] = { >> > + "uart2_cts_n_pj5", >> > + "uart2_rts_n_pj6", >> > + "uart3_txd_pw6", >> > + "uart3_rxd_pw7", >> > + "uart3_cts_n_pa1", >> > + "uart3_rts_n_pc0", >> > + >> > + "pu0", >> >> It'd be best not to have blank lines in the middle of arrays. The same comment exists elsewhere in the >> file, so make sure you search the whole file. Nits: - There are some cases of multiple blank lines back-to-back. - There's a blank line at the end of the file. Aside from those minor issues, patches 1/4 and 4/4, Acked-by: Stephen Warren (BTW, those 2 patches would go through the pinctrl tree, and patches 2/4 and 3/4 would go through the Tegra tree. You generally shouldn't posted patches that will be applied to different trees in the same series, since there aren't dependencies).