From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574Ab3LFGIR (ORCPT ); Fri, 6 Dec 2013 01:08:17 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:7681 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763Ab3LFGIP (ORCPT ); Fri, 6 Dec 2013 01:08:15 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 05 Dec 2013 22:01:30 -0800 Message-ID: <52A16924.6040902@nvidia.com> Date: Fri, 6 Dec 2013 11:35:24 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Stephen Warren CC: "linus.walleij@linaro.org" , "rob.herring@calxeda.com" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "thierry.reding@gmail.com" , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi References: <1386241070-4350-1-git-send-email-ldewangan@nvidia.com> <1386241070-4350-3-git-send-email-ldewangan@nvidia.com> <52A10932.1040903@wwwdotorg.org> <52A10A13.2020608@wwwdotorg.org> In-Reply-To: <52A10A13.2020608@wwwdotorg.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 06 December 2013 04:49 AM, Stephen Warren wrote: > On 12/05/2013 04:16 PM, Stephen Warren wrote: >> On 12/05/2013 03:57 AM, Laxman Dewangan wrote: >>> The tegra124 pinmux controller is identical to tegra114 with >>> removing some of existing pins from T114 and adding new pins. >> I already sent this patch. > Oh, I do notice one difference between the two patches: > > Mine: > >> + reg = <0x70000868 0x148>, /* Pad control registers */ >> + <0x70003000 0x40c>; /* Mux registers */ > Yours: > >> + reg = <0x70000868 0x164 /* Pad control registers */ >> + 0x70003000 0x434>; /* PinMux registers */ > Are the increase register lengths in your patch correct? If so, I guess > I'll drop my patch and replace it with yours if you fix up the unit address. Yes, the last entry of the bank 0 and 1 are: DRV_PINGROUP(ao4, 0x9c8, 2, 3, 4, 12, 7, 20, 7, 28, 2, 30, 2, Y), and PINGROUP(dp_hpd_pff0, DP, RSVD2, RSVD3, RSVD4, DP, 0x3430, N, N, N),