public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] ramdisk: documentation update
@ 2013-12-06 23:52 Fabian Frederick
  2013-12-08  3:19 ` Randy Dunlap
  0 siblings, 1 reply; 6+ messages in thread
From: Fabian Frederick @ 2013-12-06 23:52 UTC (permalink / raw)
  To: linux-kernel; +Cc: npiggin

-ramdisk_blocksize doesn't exist anymore.
-Module parameters added to documentation.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 Documentation/blockdev/ramdisk.txt | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/Documentation/blockdev/ramdisk.txt b/Documentation/blockdev/ramdisk.txt
index fa72e97..5dca7b1 100644
--- a/Documentation/blockdev/ramdisk.txt
+++ b/Documentation/blockdev/ramdisk.txt
@@ -36,21 +36,30 @@ allowing one to squeeze more programs onto an average installation or
 rescue floppy disk.
 
 
-2) Kernel Command Line Parameters
+2) Parameters
 ---------------------------------
 
+2a) Kernel Command Line Parameters
+
 	ramdisk_size=N
 	==============
 
 This parameter tells the RAM disk driver to set up RAM disks of N k size.  The
 default is 4096 (4 MB) (8192 (8 MB) on S390).
 
-	ramdisk_blocksize=N
-	===================
+2b) Module parameters
+
+	rd_nr
+	=====
+	/dev/ramX devices created.
 
-This parameter tells the RAM disk driver how many bytes to use per block.  The
-default is 1024 (BLOCK_SIZE).
+	max_part
+	========
+	Maximum partition number.
 
+	rd_size
+	=======
+	cf ramdisk_size.
 
 3) Using "rdev -r"
 ------------------
@@ -157,6 +166,10 @@ users may wish to combine steps (d) and (f) by using a pipe.
 Changelog:
 ----------
 
+12-2013 :	Removed ramdisk_blocksize (obsolete)
+		Adding module parameters.
+		Fabian Frederick <fabf@skynet.be>
+
 10-22-04 :	Updated to reflect changes in command line options, remove
 		obsolete references, general cleanup.
 		James Nelson (james4765@gmail.com)
-- 
1.8.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ramdisk: documentation update
  2013-12-06 23:52 Fabian Frederick
@ 2013-12-08  3:19 ` Randy Dunlap
  2013-12-08  8:35   ` Fabian Frederick
  0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2013-12-08  3:19 UTC (permalink / raw)
  To: Fabian Frederick, linux-kernel; +Cc: npiggin

On 12/06/13 15:52, Fabian Frederick wrote:
> -ramdisk_blocksize doesn't exist anymore.
> -Module parameters added to documentation.
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  Documentation/blockdev/ramdisk.txt | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/blockdev/ramdisk.txt b/Documentation/blockdev/ramdisk.txt
> index fa72e97..5dca7b1 100644
> --- a/Documentation/blockdev/ramdisk.txt
> +++ b/Documentation/blockdev/ramdisk.txt
> @@ -36,21 +36,30 @@ allowing one to squeeze more programs onto an average installation or
>  rescue floppy disk.
>  
>  
> -2) Kernel Command Line Parameters
> +2) Parameters
>  ---------------------------------
>  
> +2a) Kernel Command Line Parameters
> +
>  	ramdisk_size=N
>  	==============
>  
>  This parameter tells the RAM disk driver to set up RAM disks of N k size.  The
>  default is 4096 (4 MB) (8192 (8 MB) on S390).

I don't find any place that S390 changes CONFIG_BLK_DEV_RAM_SIZE from its default
of 4096 to 8192.  Did you?  If so, where please?


>  
> -	ramdisk_blocksize=N
> -	===================
> +2b) Module parameters
> +
> +	rd_nr
> +	=====
> +	/dev/ramX devices created.
>  
> -This parameter tells the RAM disk driver how many bytes to use per block.  The
> -default is 1024 (BLOCK_SIZE).
> +	max_part
> +	========
> +	Maximum partition number.
>  
> +	rd_size
> +	=======
> +	cf ramdisk_size.

Compare to ramdisk_size?  how about

	See ramdisk_size.
or
	Same as ramdisk_size.

>  
>  3) Using "rdev -r"
>  ------------------


As for the Changelog, it would be better just to delete all of it.
That's what git is for (and good at).


-- 
~Randy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ramdisk: documentation update
  2013-12-08  3:19 ` Randy Dunlap
@ 2013-12-08  8:35   ` Fabian Frederick
  2013-12-08 17:21     ` Randy Dunlap
  0 siblings, 1 reply; 6+ messages in thread
From: Fabian Frederick @ 2013-12-08  8:35 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-kernel, npiggin

On Sat, 07 Dec 2013 19:19:11 -0800
Randy Dunlap wrote:

> On 12/06/13 15:52, Fabian Frederick wrote:
> > -ramdisk_blocksize doesn't exist anymore.
> > -Module parameters added to documentation.
> > 
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> > ---
> >  Documentation/blockdev/ramdisk.txt | 23 ++++++++++++++++++-----
> >  1 file changed, 18 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Documentation/blockdev/ramdisk.txt b/Documentation/blockdev/ramdisk.txt
> > index fa72e97..5dca7b1 100644
> > --- a/Documentation/blockdev/ramdisk.txt
> > +++ b/Documentation/blockdev/ramdisk.txt
> > @@ -36,21 +36,30 @@ allowing one to squeeze more programs onto an average installation or
> >  rescue floppy disk.
> >  
> >  
> > -2) Kernel Command Line Parameters
> > +2) Parameters
> >  ---------------------------------
> >  
> > +2a) Kernel Command Line Parameters
> > +
> >  	ramdisk_size=N
> >  	==============
> >  
> >  This parameter tells the RAM disk driver to set up RAM disks of N k size.  The
> >  default is 4096 (4 MB) (8192 (8 MB) on S390).
> 
> I don't find any place that S390 changes CONFIG_BLK_DEV_RAM_SIZE from its default
> of 4096 to 8192.  Did you?  If so, where please?

You're right, it's an old S390 recommendation.I'm removing it as well :)

> 
> 
> >  
> > -	ramdisk_blocksize=N
> > -	===================
> > +2b) Module parameters
> > +
> > +	rd_nr
> > +	=====
> > +	/dev/ramX devices created.
> >  
> > -This parameter tells the RAM disk driver how many bytes to use per block.  The
> > -default is 1024 (BLOCK_SIZE).
> > +	max_part
> > +	========
> > +	Maximum partition number.
> >  
> > +	rd_size
> > +	=======
> > +	cf ramdisk_size.
> 
> Compare to ramdisk_size?  how about
> 
> 	See ramdisk_size.
> or
> 	Same as ramdisk_size.

ok.
> 
> >  
> >  3) Using "rdev -r"
> >  ------------------
> 
> 
> As for the Changelog, it would be better just to delete all of it.
> That's what git is for (and good at).

Git only gives post 2008 updates.I guess we keep previous changelogs in text mode where 
available ?

I had no reaction to this patch (also about ramdisk) 
https://lkml.org/lkml/2013/12/6/748
Should I merge it to this one ?

> 
> 
> -- 
> ~Randy

Fabian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ramdisk: documentation update
@ 2013-12-08 11:28 Fabian Frederick
  2013-12-09  3:59 ` Randy Dunlap
  0 siblings, 1 reply; 6+ messages in thread
From: Fabian Frederick @ 2013-12-08 11:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: axboe, akpm, npiggin, rdunlap

-ramdisk_blocksize doesn't exist anymore
-Module parameters added to documentation

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 Documentation/blockdev/ramdisk.txt | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/Documentation/blockdev/ramdisk.txt b/Documentation/blockdev/ramdisk.txt
index fa72e97..fe2ef97 100644
--- a/Documentation/blockdev/ramdisk.txt
+++ b/Documentation/blockdev/ramdisk.txt
@@ -36,21 +36,30 @@ allowing one to squeeze more programs onto an average installation or
 rescue floppy disk.
 
 
-2) Kernel Command Line Parameters
+2) Parameters
 ---------------------------------
 
+2a) Kernel Command Line Parameters
+
 	ramdisk_size=N
 	==============
 
 This parameter tells the RAM disk driver to set up RAM disks of N k size.  The
-default is 4096 (4 MB) (8192 (8 MB) on S390).
+default is 4096 (4 MB).
+
+2b) Module parameters
 
-	ramdisk_blocksize=N
-	===================
+	rd_nr
+	=====
+	/dev/ramX devices created.
 
-This parameter tells the RAM disk driver how many bytes to use per block.  The
-default is 1024 (BLOCK_SIZE).
+	max_part
+	========
+	Maximum partition number.
 
+	rd_size
+	=======
+	See ramdisk_size.
 
 3) Using "rdev -r"
 ------------------
-- 
1.8.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ramdisk: documentation update
  2013-12-08  8:35   ` Fabian Frederick
@ 2013-12-08 17:21     ` Randy Dunlap
  0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2013-12-08 17:21 UTC (permalink / raw)
  To: Fabian Frederick; +Cc: linux-kernel, npiggin

On 12/08/13 00:35, Fabian Frederick wrote:
> 
> I had no reaction to this patch (also about ramdisk) 
> https://lkml.org/lkml/2013/12/6/748
> Should I merge it to this one ?

Your choice.  You could merge them and then add
Jens Axboe and Andrew Morton as recipients on the new patch.

thanks,
-- 
~Randy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ramdisk: documentation update
  2013-12-08 11:28 [PATCH 1/1] ramdisk: documentation update Fabian Frederick
@ 2013-12-09  3:59 ` Randy Dunlap
  0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2013-12-09  3:59 UTC (permalink / raw)
  To: Fabian Frederick, linux-kernel; +Cc: axboe, akpm, npiggin

On 12/08/13 03:28, Fabian Frederick wrote:
> -ramdisk_blocksize doesn't exist anymore
> -Module parameters added to documentation
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.


> ---
>  Documentation/blockdev/ramdisk.txt | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/blockdev/ramdisk.txt b/Documentation/blockdev/ramdisk.txt
> index fa72e97..fe2ef97 100644
> --- a/Documentation/blockdev/ramdisk.txt
> +++ b/Documentation/blockdev/ramdisk.txt
> @@ -36,21 +36,30 @@ allowing one to squeeze more programs onto an average installation or
>  rescue floppy disk.
>  
>  
> -2) Kernel Command Line Parameters
> +2) Parameters
>  ---------------------------------
>  
> +2a) Kernel Command Line Parameters
> +
>  	ramdisk_size=N
>  	==============
>  
>  This parameter tells the RAM disk driver to set up RAM disks of N k size.  The
> -default is 4096 (4 MB) (8192 (8 MB) on S390).
> +default is 4096 (4 MB).
> +
> +2b) Module parameters
>  
> -	ramdisk_blocksize=N
> -	===================
> +	rd_nr
> +	=====
> +	/dev/ramX devices created.
>  
> -This parameter tells the RAM disk driver how many bytes to use per block.  The
> -default is 1024 (BLOCK_SIZE).
> +	max_part
> +	========
> +	Maximum partition number.
>  
> +	rd_size
> +	=======
> +	See ramdisk_size.
>  
>  3) Using "rdev -r"
>  ------------------
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-12-09  3:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-08 11:28 [PATCH 1/1] ramdisk: documentation update Fabian Frederick
2013-12-09  3:59 ` Randy Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2013-12-06 23:52 Fabian Frederick
2013-12-08  3:19 ` Randy Dunlap
2013-12-08  8:35   ` Fabian Frederick
2013-12-08 17:21     ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox