From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>, linus.walleij@linaro.org
Cc: rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
rob@landley.net, thierry.reding@gmail.com,
grant.likely@linaro.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, Ashwini Ghuge <aghuge@nvidia.com>
Subject: Re: [PATCH V2 2/2] pinctrl: tegra: add pinmux controller driver for Tegra124
Date: Mon, 09 Dec 2013 11:27:38 -0700 [thread overview]
Message-ID: <52A60B9A.7010709@wwwdotorg.org> (raw)
In-Reply-To: <1386585140-1137-2-git-send-email-ldewangan@nvidia.com>
On 12/09/2013 03:32 AM, Laxman Dewangan wrote:
> From: Ashwini Ghuge <aghuge@nvidia.com>
>
> This adds a driver for the Tegra124 pinmux, and required
> parameterization data for Tegra124.
>
> The driver uses the common Tegra pincontrol driver utility
> functions to implement the majority of the driver.
>
> This driver is not compatible with the earlier NVIDIA's SoCs,
> hence add new compatibile as "nvidia,tegra124-pinmux".
>
> Originally written by Ashwini Gguhe.
> Thierry:
> - Cleanups in patches.
> ldewangan:
> - Fix some entries for groups.
> - Fix MUX enums and group sequence.
> +static const struct pinctrl_pin_desc tegra124_pins[] = {
Still two spaces there...
BTW, I said the following before for both patches; please make sure you
add this to the commit description...
Acked-by: Stephen Warren <swarren@nvidia.com>
Even if I didn't say it before, it's certainly now,
Tested-by: Stephen Warren <swarren@nvidia.com>
(I also tested your patches that add the pinctrl DT entries to the
Venice2 DT file. Thanks.)
next prev parent reply other threads:[~2013-12-09 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 10:32 [PATCH V2 1/2] pinctrl: tegra: Add devicetree binding document for Tegra124 Laxman Dewangan
2013-12-09 10:32 ` [PATCH V2 2/2] pinctrl: tegra: add pinmux controller driver " Laxman Dewangan
2013-12-09 18:27 ` Stephen Warren [this message]
2013-12-09 10:51 ` [PATCH V2 1/2] pinctrl: tegra: Add devicetree binding document " Mark Rutland
2013-12-09 17:39 ` Stephen Warren
2013-12-09 17:48 ` Mark Rutland
2013-12-09 18:11 ` Stephen Warren
2013-12-12 18:22 ` Linus Walleij
2013-12-12 18:38 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A60B9A.7010709@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=aghuge@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox