Re: [PATCH] perf tools: Fix bug for perf kvm report without guestmount.

Dongsheng Yang
2013-12-09T05:46:13Z

>> When more than 1 VM, the cases you provided is all about
>> record-report the symbols from __all__ guests. How about I want to
>> record-report one of them?
>> Example:
>> There are 2 guests are running different kernels, I want to
>> record-report VM1.
>>
>> Currently, we can use --guestmount to get the symbols of VM1, but we
>> can not remove the symbols of VM2 from report. It means the
>> percentage of each symbol is not the symbol only in this VM1.
>>
>> What I want with introducing guestpid is to record-report the symbols
>> only from VM1, and ignore VM2.
>>
>
> Besides, as we provide two usages of perf-kvm in manpage,
> guestmount-way and guest{kallsyms,modules}-way, but the
> guest{kallsyms, modules} is not used
s/not/only. Sorry for the typo :(
> when
> there is only one guest is running, the guestmount is used in all
> situations, it seems not reasonable. I think we can provide a guestpid
> to make the guestkallsyms-way can be used in any situation.
>
> This way, user can understand and choose the usage easily.
>
> 1. one or more guests you want to record-report, --guestmount-way. It
> provides the full functionality of perf kvm.
>
> 2. only one guest you want to record-report, --guestmount is also
> available, and there is another usage for this most used case as a
> shortcut , --guest{kallsyms, modules, pid}.
>
> Then the relationship between the two kinds of usage is more clear,
> right? And in this way, we can make the result of perf-kvm more
> foreseeable to user.
>
>>> David
>>>
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>