From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix bug for perf kvm report without guestmount.
Date: Mon, 09 Dec 2013 12:42:59 -0700 [thread overview]
Message-ID: <52A61D43.6020007@gmail.com> (raw)
In-Reply-To: <20131209184901.GE8098@ghostprotocols.net>
On 12/9/13, 11:49 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Dec 09, 2013 at 11:08:05AM -0700, David Ahern escreveu:
>> On 12/9/13, 11:07 AM, Arnaldo Carvalho de Melo wrote:
>>> Em Sun, Dec 08, 2013 at 10:39:36AM -0700, David Ahern escreveu:
>>>> On 12/6/13, 4:56 AM, Arnaldo Carvalho de Melo wrote:
>>>>> You get correct results because the modules/kallsyms info you provided
>>>>> matches the VM you're testing, i.e. the pid test is not needed.
>>>>>
>>>>> I think we need to specify for which PID the --guestmodules and
>>>>> --guestkallsyms is provided, so that it can refuse to use it for pids
>>>>> where it is invalid.
>>>>
>>>> Those are arguments are shortcut defaults for guests. If the VMs are
>>>> not running the same kernel use guestmount and pid specific
>>>> directories. e.g.,
>>>>
>>>> /tmp/guestmount/<pid>/proc/kallsyms
>>>
>>> Does this already works like that? /me tries to figure that out...
>>
>> yes.
>>
>
> Yeah, I saw that:
>
> if ((pid != HOST_KERNEL_ID) &&
> (pid != DEFAULT_GUEST_KERNEL_ID) &&
> (symbol_conf.guestmount)) {
> sprintf(path, "%s/%d", symbol_conf.guestmount, pid);
>
> So, in summary, ack/nack this patch?
>
NACK. Not needed and breaks the very intent of those 2 options.
David
next prev parent reply other threads:[~2013-12-09 19:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 21:33 [PATCH] perf tools: Fix bug for perf kvm report without guestmount Dongsheng Yang
2013-12-06 11:56 ` Arnaldo Carvalho de Melo
2013-12-08 17:39 ` David Ahern
2013-12-09 18:07 ` Arnaldo Carvalho de Melo
2013-12-09 18:08 ` David Ahern
2013-12-09 18:49 ` Arnaldo Carvalho de Melo
2013-12-09 19:42 ` David Ahern [this message]
2013-12-10 18:54 ` Dongsheng Yang
2013-12-10 6:02 ` David Ahern
2013-12-10 19:07 ` Dongsheng Yang
2013-12-16 16:26 ` [PATCH V2] " Dongsheng Yang
2013-12-16 16:36 ` Dongsheng Yang
2013-12-20 5:31 ` David Ahern
2013-12-20 18:37 ` Dongsheng Yang
2013-12-20 18:41 ` [PATCH V3] " Dongsheng Yang
2013-12-20 5:46 ` David Ahern
2014-01-12 18:36 ` [tip:perf/core] perf kvm: Fix " tip-bot for Dongsheng Yang
2013-12-09 15:20 ` [PATCH] perf tools: Fix bug for perf " Dongsheng Yang
2013-12-09 3:42 ` David Ahern
2013-12-09 17:12 ` Dongsheng Yang
2013-12-09 4:32 ` David Ahern
2013-12-09 18:06 ` Dongsheng Yang
2013-12-09 18:41 ` Dongsheng Yang
2013-12-09 18:44 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A61D43.6020007@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox