* [PATCH][RESEND] ARM: SAMSUNG: remove IRQF_DISABLED
[not found] <000801cec874$%han@samsung.com>
@ 2013-12-09 9:02 ` Michael Opdenacker
2013-12-09 21:17 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Michael Opdenacker @ 2013-12-09 9:02 UTC (permalink / raw)
To: ben-linux, kgene.kim, linux
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel,
Michael Opdenacker
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
---
arch/arm/mach-s3c24xx/dma.c | 2 +-
arch/arm/mach-s3c24xx/simtec-usb.c | 3 +--
arch/arm/mach-s3c64xx/mach-smartq.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/dma.c b/arch/arm/mach-s3c24xx/dma.c
index 4a65cba3295d..a8dafc174fe3 100644
--- a/arch/arm/mach-s3c24xx/dma.c
+++ b/arch/arm/mach-s3c24xx/dma.c
@@ -742,7 +742,7 @@ int s3c2410_dma_request(enum dma_ch channel,
chan->irq_claimed = 1;
local_irq_restore(flags);
- err = request_irq(chan->irq, s3c2410_dma_irq, IRQF_DISABLED,
+ err = request_irq(chan->irq, s3c2410_dma_irq, 0,
client->name, (void *)chan);
local_irq_save(flags);
diff --git a/arch/arm/mach-s3c24xx/simtec-usb.c b/arch/arm/mach-s3c24xx/simtec-usb.c
index 2ed2e32430dc..bb3eac6a7697 100644
--- a/arch/arm/mach-s3c24xx/simtec-usb.c
+++ b/arch/arm/mach-s3c24xx/simtec-usb.c
@@ -78,8 +78,7 @@ static void usb_simtec_enableoc(struct s3c2410_hcd_info *info, int on)
if (on) {
ret = request_irq(BAST_IRQ_USBOC, usb_simtec_ocirq,
- IRQF_DISABLED | IRQF_TRIGGER_RISING |
- IRQF_TRIGGER_FALLING,
+ IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
"USB Over-current", info);
if (ret != 0) {
printk(KERN_ERR "failed to request usb oc irq\n");
diff --git a/arch/arm/mach-s3c64xx/mach-smartq.c b/arch/arm/mach-s3c64xx/mach-smartq.c
index a6b338fd0470..08a889c141da 100644
--- a/arch/arm/mach-s3c64xx/mach-smartq.c
+++ b/arch/arm/mach-s3c64xx/mach-smartq.c
@@ -106,7 +106,7 @@ static void smartq_usb_host_enableoc(struct s3c2410_hcd_info *info, int on)
if (on) {
ret = request_irq(gpio_to_irq(S3C64XX_GPL(10)),
- smartq_usb_host_ocirq, IRQF_DISABLED |
+ smartq_usb_host_ocirq,
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
"USB host overcurrent", info);
if (ret != 0)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][RESEND] ARM: SAMSUNG: remove IRQF_DISABLED
2013-12-09 9:02 ` [PATCH][RESEND] ARM: SAMSUNG: remove IRQF_DISABLED Michael Opdenacker
@ 2013-12-09 21:17 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2013-12-09 21:17 UTC (permalink / raw)
To: Michael Opdenacker
Cc: ben-linux, kgene.kim, linux, linux-samsung-soc, linux-kernel,
linux-arm-kernel
On 12/09/13 18:02, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker<michael.opdenacker@free-electrons.com>
> Reviewed-by: Jingoo Han<jg1.han@samsung.com>
> ---
> arch/arm/mach-s3c24xx/dma.c | 2 +-
> arch/arm/mach-s3c24xx/simtec-usb.c | 3 +--
> arch/arm/mach-s3c64xx/mach-smartq.c | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/dma.c b/arch/arm/mach-s3c24xx/dma.c
> index 4a65cba3295d..a8dafc174fe3 100644
> --- a/arch/arm/mach-s3c24xx/dma.c
> +++ b/arch/arm/mach-s3c24xx/dma.c
> @@ -742,7 +742,7 @@ int s3c2410_dma_request(enum dma_ch channel,
> chan->irq_claimed = 1;
> local_irq_restore(flags);
>
> - err = request_irq(chan->irq, s3c2410_dma_irq, IRQF_DISABLED,
> + err = request_irq(chan->irq, s3c2410_dma_irq, 0,
> client->name, (void *)chan);
>
> local_irq_save(flags);
> diff --git a/arch/arm/mach-s3c24xx/simtec-usb.c b/arch/arm/mach-s3c24xx/simtec-usb.c
> index 2ed2e32430dc..bb3eac6a7697 100644
> --- a/arch/arm/mach-s3c24xx/simtec-usb.c
> +++ b/arch/arm/mach-s3c24xx/simtec-usb.c
> @@ -78,8 +78,7 @@ static void usb_simtec_enableoc(struct s3c2410_hcd_info *info, int on)
>
> if (on) {
> ret = request_irq(BAST_IRQ_USBOC, usb_simtec_ocirq,
> - IRQF_DISABLED | IRQF_TRIGGER_RISING |
> - IRQF_TRIGGER_FALLING,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> "USB Over-current", info);
> if (ret != 0) {
> printk(KERN_ERR "failed to request usb oc irq\n");
> diff --git a/arch/arm/mach-s3c64xx/mach-smartq.c b/arch/arm/mach-s3c64xx/mach-smartq.c
> index a6b338fd0470..08a889c141da 100644
> --- a/arch/arm/mach-s3c64xx/mach-smartq.c
> +++ b/arch/arm/mach-s3c64xx/mach-smartq.c
> @@ -106,7 +106,7 @@ static void smartq_usb_host_enableoc(struct s3c2410_hcd_info *info, int on)
>
> if (on) {
> ret = request_irq(gpio_to_irq(S3C64XX_GPL(10)),
> - smartq_usb_host_ocirq, IRQF_DISABLED |
> + smartq_usb_host_ocirq,
> IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> "USB host overcurrent", info);
> if (ret != 0)
Looks OK to me, applied.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-09 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <000801cec874$%han@samsung.com>
2013-12-09 9:02 ` [PATCH][RESEND] ARM: SAMSUNG: remove IRQF_DISABLED Michael Opdenacker
2013-12-09 21:17 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox